[Django] #28226: Remove use of deprecated ''.join() pattern
Django
------------------------------------------------+------------------------
Reporter: James Bennett | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
From Lennart Regebro's PyCon 2017 talk: we're using this in
django/http/multipartparser.py where it's no longer necessary
(concatenation is now faster on every version of Python we support).
--
Ticket URL: <https://code.djangoproject.com/ticket/28226>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: James Bennett | Owner: nobody
Cleanup/optimization |
Component: HTTP handling | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
Any pointer to the Python docs or any other reference article?
--
Ticket URL: <https://code.djangoproject.com/ticket/28226#comment:1>
Django
Reporter: James Bennett | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Oh, I didn't see the [https://github.com/django/django/pull/8520 PR] at
first. Is it WIP? Should we search for other patterns like this?
--
Ticket URL: <https://code.djangoproject.com/ticket/28226#comment:2>
Django
Reporter: James Bennett | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tom):
I added another patch here: https://github.com/django/django/pull/8527
I fixed all the places I could find where `.join` has static arguments,
there could be a few left (there are a lot of join statements in Django!).
--
Ticket URL: <https://code.djangoproject.com/ticket/28226#comment:3>
Django
Reporter: James Bennett | Owner: nobody
Component: HTTP handling | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"7afb47646920ab3835dfa1750257dace01883a4b" 7afb476]:
{{{
#!CommitTicketReference repository=""
revision="7afb47646920ab3835dfa1750257dace01883a4b"
Fixed #28226 -- Replaced use of str.join() with concatenation.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28226#comment:4>