[Django] #26734: Make iterator class configurable on ModelChoiceField

15 views
Skip to first unread message

Django

unread,
Jun 9, 2016, 10:59:11 AM6/9/16
to django-...@googlegroups.com
#26734: Make iterator class configurable on ModelChoiceField
------------------------------------------------+------------------------
Reporter: dsanders11 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Currently isn't trivial to change the iterator class used for a subclass
of `ModelChoiceField` since it is hardcoded in `_get_choices`, which is
then used in a property. This means a subclass has to duplicate code and
create the property again to change the iterator class.

--
Ticket URL: <https://code.djangoproject.com/ticket/26734>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 9, 2016, 11:00:14 AM6/9/16
to django-...@googlegroups.com
#26734: Make iterator class configurable on ModelChoiceField
-------------------------------------+-------------------------------------
Reporter: dsanders11 | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Forms | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* reporter: dsanders11 => dsanders11
* stage: Unreviewed => Ready for checkin


Comment:

[https://github.com/django/django/pull/6572 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26734#comment:1>

Django

unread,
Jun 9, 2016, 11:11:20 AM6/9/16
to django-...@googlegroups.com
#26734: Make iterator class configurable on ModelChoiceField
-------------------------------------+-------------------------------------
Reporter: dsanders11 | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Forms | Version: 1.9
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"5ec64f96b2d83ec3c0ef574f52e4767a440017b8" 5ec64f96]:
{{{
#!CommitTicketReference repository=""
revision="5ec64f96b2d83ec3c0ef574f52e4767a440017b8"
Fixed #26734 -- Made iterator class configurable on ModelChoiceField.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26734#comment:2>

Reply all
Reply to author
Forward
0 new messages