[Django] #32863: Model.check() crashes on Django 3.2 with invalid app label
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de | Owner: nobody
Silvio |
Type: Bug | Status: new
Component: Database | Version: 3.2
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I found this issue in `django-cryptography` lib
(https://github.com/georgemarshall/django-cryptography). They have a test
with an invalid `app_label`, I'd expect model check to return `False`, but
it crashes when `DEFAULT_AUTO_FIELD` is not defined, because
`_meta.app_config=None` .
{{{
In [1]: from django.db import models
...: class Foo(models.Model):
...: class Meta:
...: app_label = 'bar'
...:
In [2]: Foo.check()
---------------------------------------------------------------------------
AttributeError Traceback (most recent call
last)
<ipython-input-2-f17a07bccce5> in <module>
----> 1 Foo.check()
~django/db/models/base.py in check(cls, **kwargs)
1291 *cls._check_ordering(),
1292 *cls._check_constraints(databases),
-> 1293 *cls._check_default_pk(),
1294 ]
1295
~django/db/models/base.py in _check_default_pk(cls)
1307 ) and
1308 not settings.is_overridden('DEFAULT_AUTO_FIELD') and
-> 1309 not
cls._meta.app_config._is_default_auto_field_overridden
1310 ):
1311 return [
AttributeError: 'NoneType' object has no attribute
'_is_default_auto_field_overridden'
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32863>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
Thanks for reporting.
Reproduced at 225d96533a8e05debd402a2bfe566487cc27d95f.
Regression in b5e12d490af3debca8c55ab3c1698189fdedbbdb.
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:1>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: nobody
Component: Database layer | Version: 3.2
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* severity: Normal => Release blocker
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:2>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Hasan Ramezani
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:3>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/14549 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:4>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:5>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:6>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Hasan
| Ramezani
Type: Bug | Status: assigned
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:7>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Hasan
| Ramezani
Component: Database layer | Version: 3.2
(models, ORM) |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7a9745fed498f69c46a3ffa5dfaff872e0e1df89" 7a9745fe]:
{{{
#!CommitTicketReference repository=""
revision="7a9745fed498f69c46a3ffa5dfaff872e0e1df89"
Fixed #32863 -- Skipped system check for specifying type of auto-created
primary keys on models with invalid app_label.
Regression in b5e12d490af3debca8c55ab3c1698189fdedbbdb.
Thanks Iuri de Silvio for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:8>
Django
DEFAULT_AUTO_FIELD
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Hasan
| Ramezani
Type: Bug | Status: closed
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"8b2b627f34797b8d497451350b35d7a5103b016e" 8b2b627f]:
{{{
#!CommitTicketReference repository=""
revision="8b2b627f34797b8d497451350b35d7a5103b016e"
[3.2.x] Fixed #32863 -- Skipped system check for specifying type of auto-
created primary keys on models with invalid app_label.
Regression in b5e12d490af3debca8c55ab3c1698189fdedbbdb.
Thanks Iuri de Silvio for the report.
Backport of 7a9745fed498f69c46a3ffa5dfaff872e0e1df89 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32863#comment:9>