[Django] #30623: Remove duplicate call to `self.update` on RequestContext

20 views
Skip to first unread message

Django

unread,
Jul 7, 2019, 6:32:16 PM7/7/19
to django-...@googlegroups.com
#30623: Remove duplicate call to `self.update` on RequestContext
-------------------------------------+-------------------------------------
Reporter: Federico | Owner: nobody
Jaramillo Martínez |
Type: | Status: new
Uncategorized |
Component: | Version: master
Uncategorized |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
There is a duplicate call to `self.update` on `__init__` of `class
RequestContext`.

This patch just removes one of them.

--
Ticket URL: <https://code.djangoproject.com/ticket/30623>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 7, 2019, 6:58:58 PM7/7/19
to django-...@googlegroups.com
#30623: Remove duplicate call to `self.update` on RequestContext
-------------------------------------+-------------------------------------
Reporter: Federico Jaramillo | Owner: nobody
Martínez |
Type: Uncategorized | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Federico Jaramillo Martínez:

Old description:

> There is a duplicate call to `self.update` on `__init__` of `class
> RequestContext`.
>
> This patch just removes one of them.

New description:

There is a duplicate call to `self.update` on `__init__` of `class
RequestContext`.

This patch just removes one of them.

https://github.com/django/django/pull/11545

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30623#comment:1>

Django

unread,
Jul 8, 2019, 1:02:27 AM7/8/19
to django-...@googlegroups.com
#30623: Remove duplicate call to `self.update` on RequestContext
-------------------------------------+-------------------------------------
Reporter: Federico Jaramillo | Owner: nobody
Martínez |
Type: | Status: closed
Cleanup/optimization |
Component: Template system | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => closed
* type: Uncategorized => Cleanup/optimization
* component: Uncategorized => Template system
* resolution: => invalid


Comment:

`update()` call is necessary (see
[https://github.com/django/django/pull/11545#issuecomment-509038714
comment]).

--
Ticket URL: <https://code.djangoproject.com/ticket/30623#comment:2>

Reply all
Reply to author
Forward
0 new messages