[Django] #31516: Change automatic migration naming from date-based to operation-based
Django
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: nobody
(Chainz) Johnson |
Type: New | Status: assigned
feature |
Component: | Version: 3.0
Migrations |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Following #31468 and a [https://groups.google.com/d/msg/django-
developers/Bmcd779Wdl4/mlQRVNVgAQAJ discussion on django-developers with
broad consensus], change the way migrations are automatically named from
date-based to operation-based. That is never name migrations based upon
the current date (`auto_YYYYMMDD`) and instead always based on the
operations they contain, rather than the current behaviour which uses
either style.
--
Ticket URL: <https://code.djangoproject.com/ticket/31516>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Johnson |
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
It looks like a luke-warmish OK on the list, so I guess we should push it
forward to review. Thanks Adam.
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:1>
Django
-------------------------------------+-------------------------------------
Johnson |
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Carles Pina Estany (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:2>
Django
-------------------------------------+-------------------------------------
Johnson | (Chainz) Johnson
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Adam (Chainz) Johnson
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:3>
Django
Reporter: Adam Johnson | Owner: Adam Johnson
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Manav Agarwal):
Just a vague idea but I personally feel would be good to implement. In
order to avoid ellipsis in the name refer
[https://github.com/django/django/pull/12799#issuecomment-636657427 this
comment]. We may add a suffix like **"_+26"** (in case there are 26 other
changes).
This is just a vague representation but I feel if we may implement
something like this, it would be a better option. Need some suggestions.
I would be happy to submit a PR for this.
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:4>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Manav Agarwal):
* owner: Adam Johnson => Manav Agarwal
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:5>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Manav Agarwal):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:6>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/14109 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:7>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Manav Agarwal):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:8>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:9>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Manav Agarwal):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:10>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:11>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Manav Agarwal):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:12>
Django
Reporter: Adam Johnson | Owner: Manav Agarwal
Type: New feature | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"b1cb923883829b8e2d3d550ba125e574979d8230" b1cb9238]:
{{{
#!CommitTicketReference repository=""
revision="b1cb923883829b8e2d3d550ba125e574979d8230"
Refs #31516, Refs #31703 -- Made makemigrations always name initial
migrations "initial".
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:13>
Django
-------------------------------------+-------------------------------------
Type: | Agarwal
Cleanup/optimization | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* type: New feature => Cleanup/optimization
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:14>
Django
-------------------------------------+-------------------------------------
Type: | Agarwal
Cleanup/optimization | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"927fead2f5dd7509541d8b0dc170a07b682cc268" 927fead2]:
{{{
#!CommitTicketReference repository=""
revision="927fead2f5dd7509541d8b0dc170a07b682cc268"
Refs #31516 -- Added Migration.suggest_name() tests for migrations with no
operations.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:15>
Django
-------------------------------------+-------------------------------------
Type: | Agarwal
Component: Migrations | Version: 3.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"99640e24b4c42a9f9b1e02d54aec72c13008276d" 99640e24]:
{{{
#!CommitTicketReference repository=""
revision="99640e24b4c42a9f9b1e02d54aec72c13008276d"
Fixed #31516 -- Improved naming of migrations with multiple operations.
52 gives 60 in total (52 + 5 + 3).
Co-authored-by: Adam Johnson <m...@adamj.eu>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31516#comment:16>