[Django] #27244: Incorrect thousand separator for the Greek locale (el)

8 views
Skip to first unread message

Django

unread,
Sep 19, 2016, 9:08:34 AM9/19/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
--------------------------------------+--------------------
Reporter: kappataumu | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
The thousand separator for the Greek locale is a dot ("."), not a non-
breaking space ("\xa0"). Other than being Greek, one can verify this like
so:

{{{
import locale
locale.setlocale(locale.LC_ALL, "el_GR.UTF-8")
print(locale.nl_langinfo(locale.THOUSEP))
}}}

A related issue (https://code.djangoproject.com/ticket/23967) previously
fixed a number of incorrect settings (see PR and discussion at
https://github.com/django/django/pull/3696) but apparently this slipped
through. Interestingly, the correct thousand separator is also documented
in one of the links shared (see http://www.localeplanet.com/java/el-GR/).

I can submit a PR if desired.

--
Ticket URL: <https://code.djangoproject.com/ticket/27244>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 19, 2016, 9:21:37 AM9/19/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
--------------------------------------+------------------------------------

Reporter: kappataumu | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0


Comment:

Sure, send a PR and have a colleague give it a +1.

--
Ticket URL: <https://code.djangoproject.com/ticket/27244#comment:1>

Django

unread,
Sep 19, 2016, 9:56:57 AM9/19/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
--------------------------------------+------------------------------------

Reporter: kappataumu | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by kappataumu):

PR sent: https://github.com/django/django/pull/7267. I've pinged @spapas
for a +1.

--
Ticket URL: <https://code.djangoproject.com/ticket/27244#comment:2>

Django

unread,
Sep 19, 2016, 4:09:58 PM9/19/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
--------------------------------------+------------------------------------

Reporter: kappataumu | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):

* has_patch: 0 => 1
* version: 1.10 => master


--
Ticket URL: <https://code.djangoproject.com/ticket/27244#comment:3>

Django

unread,
Sep 22, 2016, 7:38:46 PM9/22/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
-------------------------------------+-------------------------------------

Reporter: kappataumu | Owner: nobody
Type: Bug | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


Comment:

Good to go, pending a +1.

--
Ticket URL: <https://code.djangoproject.com/ticket/27244#comment:4>

Django

unread,
Oct 1, 2016, 10:57:50 AM10/1/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
-------------------------------------+-------------------------------------

Reporter: kappataumu | Owner: nobody
Type: Bug | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

On the pull request, there's a discussion between @kappataumu and @spapas,
and they disagreement between various usages.

Tim said the space was used in
https://en.wikipedia.org/wiki/Decimal_mark#Examples_of_use.
Extract of this same page:
`Because of the confusion that could result in international documents, in
recent years the use of spaces as separators has been advocated by the
superseded SI/ISO 31-0 standard,[17] as well as by the International
Bureau of Weights and Measures and the International Union of Pure and
Applied Chemistry, which have also begun advocating the use of a "thin
space" in "groups of three".`

The el_GR POSIX locale and the Unicode CLDR use the dot.
http://lh.2xlibre.net/locale/el_GR/
http://www.unicode.org/cldr/charts/29/summary/el.html#3616

If I should decide, I think I'd choose the traditional/official dot
character. Of course, it would be better to reach some agreement between
Greek nationals.

--
Ticket URL: <https://code.djangoproject.com/ticket/27244#comment:5>

Django

unread,
Oct 6, 2016, 11:52:47 AM10/6/16
to django-...@googlegroups.com
#27244: Incorrect thousand separator for the Greek locale (el)
-------------------------------------+-------------------------------------
Reporter: kappataumu | Owner: nobody
Type: Bug | Status: closed
Component: | Version: master
Internationalization |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"9cfd060b1c0c3664d77e4ab30a6c351822f0a4d6" 9cfd060b]:
{{{
#!CommitTicketReference repository=""
revision="9cfd060b1c0c3664d77e4ab30a6c351822f0a4d6"
Fixed #27244 -- Changed Greek's thousand separator from space to dot.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27244#comment:6>

Reply all
Reply to author
Forward
0 new messages