[Django] #25583: GEOSGeometry.transform should impose no constraints on SRID if called with CoordTransform
Django
CoordTransform
-------------------------------+--------------------
Reporter: sir-sigurd | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/25583>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
CoordTransform
Reporter: sir-sigurd | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
added PR https://github.com/django/django/pull/5457
--
Ticket URL: <https://code.djangoproject.com/ticket/25583#comment:1>
Django
CoordTransform
Reporter: sir-sigurd | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by claudep):
I'm not sure about that. I think requiring the SRID being set for a
geometry to be transformed is some sort of safeguard against badly written
code.
Maybe you could tell me about a use case where this behavior is
problematic and where defining the proper SRID beforehand is not possible?
--
Ticket URL: <https://code.djangoproject.com/ticket/25583#comment:2>
Django
CoordTransform
Reporter: sir-sigurd | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by sir-sigurd):
This behavior is problematic when you have coordinates in some custom SRS
with no SRID assigned and you need to transform these coordinates.
--
Ticket URL: <https://code.djangoproject.com/ticket/25583#comment:3>
Django
CoordTransform
Reporter: sir-sigurd | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by claudep):
* version: 1.8 => master
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
Comment:
OK, fair.
--
Ticket URL: <https://code.djangoproject.com/ticket/25583#comment:4>
Django
CoordTransform
Reporter: sir-sigurd | Owner: nobody
Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"a7bb5af50be7b0efbb784011a41fd25fdfe4d42c" a7bb5af5]:
{{{
#!CommitTicketReference repository=""
revision="a7bb5af50be7b0efbb784011a41fd25fdfe4d42c"
Fixed #25583 -- Allowed calling `transform` with `CoordTransform` even if
SRID is invalid.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25583#comment:5>