[Django] #30948: Change packaging to use setup.cfg declarative syntax

31 views
Skip to first unread message

Django

unread,
Nov 2, 2019, 12:00:44 PM11/2/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
------------------------------------------------+------------------------
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Packaging | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
setuptools feature:
https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-
setup-using-setup-cfg-files

Available since setuptools 30.3.0 (8 Dec 2016).

Using setup.cfg reduces boilerplate and logic in `setup.py`. As
`setup.cfg` is a simple data format, it could allow for automation with
external tools in the future.

--
Ticket URL: <https://code.djangoproject.com/ticket/30948>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 2, 2019, 12:03:15 PM11/2/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Packaging | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jon Dufresne):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/12013

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:1>

Django

unread,
Nov 4, 2019, 2:56:35 AM11/4/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
--------------------------------------+------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Packaging | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Nick Pope):

* stage: Unreviewed => Accepted


Comment:

I think this will make things much easier. Even `setuptools` itself does
this now.

By the time Django 3.1 is released, this will have been supported for
nearly 4 years.

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:2>

Django

unread,
Nov 5, 2019, 4:39:23 AM11/5/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
--------------------------------------+------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Packaging | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

* needs_better_patch: 0 => 1


Comment:

PR has grown in scope to incorporate a few things. (License change, other
clean ups, ...) If we can pull that out separately, we can assess this
change on it's own. (Thanks for the effort — looks good.)

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:3>

Django

unread,
Nov 5, 2019, 9:04:35 AM11/5/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
--------------------------------------+------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Packaging | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Jon Dufresne):

* needs_better_patch: 1 => 0


Comment:

Feedback addressed and reduced PR in scope.

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:4>

Django

unread,
Nov 7, 2019, 10:13:06 AM11/7/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Packaging | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:5>

Django

unread,
Nov 8, 2019, 3:18:06 PM11/8/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Packaging | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"bca2ffd3c267fecbcfb683a853f350959afee553" bca2ffd]:
{{{
#!CommitTicketReference repository=""
revision="bca2ffd3c267fecbcfb683a853f350959afee553"
[3.0.x] Refs #30948 -- Updated install instructions to use pip instead of
setup.py.

Co-authored-by: Nick Pope <nick...@flightdataservices.com>

Backport of eee4da3b5748370a5c562bc63d2cae61ea85b16c from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:6>

Django

unread,
Nov 8, 2019, 3:18:08 PM11/8/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Packaging | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"eee4da3b5748370a5c562bc63d2cae61ea85b16c" eee4da3b]:
{{{
#!CommitTicketReference repository=""
revision="eee4da3b5748370a5c562bc63d2cae61ea85b16c"


Refs #30948 -- Updated install instructions to use pip instead of
setup.py.

Co-authored-by: Nick Pope <nick...@flightdataservices.com>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:7>

Django

unread,
Nov 8, 2019, 3:18:08 PM11/8/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Packaging | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"85efc14a2edac532df1a9ad4dd9b6d4a4dcf583e" 85efc14a]:
{{{
#!CommitTicketReference repository=""
revision="85efc14a2edac532df1a9ad4dd9b6d4a4dcf583e"
Fixed #30948 -- Changed packaging to use declarative config in setup.cfg.

Co-authored-by: Nick Pope <nick...@flightdataservices.com>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:8>

Django

unread,
Nov 8, 2019, 3:18:45 PM11/8/19
to django-...@googlegroups.com
#30948: Change packaging to use setup.cfg declarative syntax
-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Packaging | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"3627fc5ee6e0ff8ff0c9bd145a642c523889547f" 3627fc5e]:
{{{
#!CommitTicketReference repository=""
revision="3627fc5ee6e0ff8ff0c9bd145a642c523889547f"
[2.2.x] Refs #30948 -- Updated install instructions to use pip instead of
setup.py.

Co-authored-by: Nick Pope <nick...@flightdataservices.com>

Backport of eee4da3b5748370a5c562bc63d2cae61ea85b16c from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30948#comment:9>

Reply all
Reply to author
Forward
0 new messages