[Django] #21642: Review AdminSite.check_dependencies

3 views
Skip to first unread message

Django

unread,
Dec 19, 2013, 4:14:14 PM12/19/13
to django-...@googlegroups.com
#21642: Review AdminSite.check_dependencies
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I just came across that method in my app-loading branch and it looks a bit
outdated -- the implementation apparently predates the introduction of
`'django.contrib.auth`'.

NB: please wait until I've merged my app loading branch to tackle this
ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/21642>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 2, 2014, 8:08:17 PM1/2/14
to django-...@googlegroups.com
#21642: Review AdminSite.check_dependencies
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by timo):

Does anything specific need to be reviewed after your changes in
2239081ff16aab1eaafea003433f7139bf13e097?

--
Ticket URL: <https://code.djangoproject.com/ticket/21642#comment:1>

Django

unread,
Jan 3, 2014, 2:07:55 AM1/3/14
to django-...@googlegroups.com
#21642: Review AdminSite.check_dependencies
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: contrib.admin | Resolution: fixed
Severity: Normal | Triage Stage:
Keywords: | Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* status: new => closed
* resolution: => fixed


Comment:

It's done, thank you.

--
Ticket URL: <https://code.djangoproject.com/ticket/21642#comment:2>

Reply all
Reply to author
Forward
0 new messages