[Django] #28971: EmailMessage.message() does not override Cc header from extra_headers dict (unlike From, To, and Reply-To)

[Django]

#28971: EmailMessage.message() does not override Cc header from extra_headers dict
(unlike From, To, and Reply-To)
------------------------------------------------+------------------------
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Mail) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Compare how CC is built:

https://github.com/django/django/blob/2.0/django/core/mail/message.py#L259

To how the other headers are built:

-
https://github.com/django/django/blob/2.0/django/core/mail/message.py#L256
-
https://github.com/django/django/blob/2.0/django/core/mail/message.py#L257
-
https://github.com/django/django/blob/2.0/django/core/mail/message.py#L261

Notice, unlike the others, Cc does not first use the `.extra_headers`
dict. Like the other headers, should be able to use the `.extra_headers`
to override Cc.

[https://github.com/django/django/pull/9454 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28971>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28971: EmailMessage.message() does not override Cc header from extra_headers dict
(unlike From, To, and Reply-To)

--------------------------------------+------------------------------------

Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Mail) | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by felixxm):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/28971#comment:1>

[Django]

#28971: EmailMessage.message() does not override Cc header from extra_headers dict
(unlike From, To, and Reply-To)

-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody

Type: | Status: new
Cleanup/optimization |

Component: Core (Mail) | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/28971#comment:2>

[Django]

#28971: EmailMessage.message() does not override Cc header from extra_headers dict
(unlike From, To, and Reply-To)

-------------------------------------+-------------------------------------

Reporter: Jon Dufresne | Owner: nobody

Type: | Status: closed
Cleanup/optimization |

Component: Core (Mail) | Version: master

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"b03d5002955256c4b3ed7cfae5150eb79c0eb97e" b03d5002]:
{{{
#!CommitTicketReference repository=""
revision="b03d5002955256c4b3ed7cfae5150eb79c0eb97e"
Fixed #28971 -- Made EmailMessage.message() set Cc from headers dict if it
exists.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28971#comment:3>