[Django] #22574: BrokenLinkEmailsMiddleware: send an email for all broken links, not just 404

21 views
Skip to first unread message

Django

unread,
May 4, 2014, 5:03:07 PM5/4/14
to django-...@googlegroups.com
#22574: BrokenLinkEmailsMiddleware: send an email for all broken links, not just
404
------------------------------+--------------------
Reporter: jdufresne | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------
Broken links can exist in ways other than 404, such as 403 errors. The
following patch modifies BrokenLinkEmailsMiddleware to send an email on
all 4xx errors.

--
Ticket URL: <https://code.djangoproject.com/ticket/22574>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 4, 2014, 8:33:12 PM5/4/14
to django-...@googlegroups.com
#22574: BrokenLinkEmailsMiddleware: send an email for all broken links, not just
404
------------------------------+--------------------------------------
Reporter: jdufresne | Owner: nobody
Type: New feature | Status: closed

Component: Core (Other) | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Changes (by russellm):

* status: new => closed
* needs_better_patch: => 0
* resolution: => wontfix
* needs_tests: => 0
* needs_docs: => 0


Comment:

Thanks for the suggestion, but I don't think this is a good idea.

Firstly, I'm not wild about the idea of increasing the volume of email on
any existing users that have this middleware installed.

Secondly, email notification isn't the right way to be handling this sort
of reporting. BrokenLinkEmailsMiddleware is a big like a vestigial tail -
it is a relic of an era when there wasn't tools like Sentry to do log
analysis. I'd rather focus our efforts on integrating better with good
logging and analysis tools, rather than expanding the capabilities of a
feature that should probably be deprecated.

Lastly, if you *really* want 403's et al to reported by email, you can do
this in your own code without difficulty.

If you'd like to advocate for this feature, feel free to open a discussion
on the Django-developers mailing list.

--
Ticket URL: <https://code.djangoproject.com/ticket/22574#comment:1>

Reply all
Reply to author
Forward
0 new messages