[Django] #29444: Allow modification of RETURNING values in django.contrib.postgres

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------
Reporter: Johannes | Owner: (none)
Hoppe |
Type: New | Status: new
feature |
Component: | Version: 2.0
contrib.postgres | Keywords: django, db,
Severity: Normal | returning, default, model, field
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Dependency for #27452

The SQL `RETURNING` statement is currently used for inserts of new
objects. Mainly it is responsible to return the primary key in a single
query.

That's great but currently in the postgres database backend this value is
hard coded to only the primary key. I would like to propose to make this
configurable.

There are plenty of uses cases for such a feature ultimately even enabling
database defaults, but I would suggest to keep it very simple for now.

I would suggest to simply allow model fields to specify if they should be
included in the returning statement or not. The default being not (except
PK) to maintain the current behavior.

The implementation as well as the related code lines have been already
discussed here:
https://github.com/django/django/pull/7525#issuecomment-354269077

I highly suggest to keep this a Postgres ONLY feature for now. That way we
can see what sticks and consider extending this functionality into
`django.db` in the future after we have seen how it's being used and
gathered feedback.

--
Ticket URL: <https://code.djangoproject.com/ticket/29444>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: (none)
Type: New feature | Status: new
Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage:
returning, default, model, field | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* version: 2.0 => master

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:1>

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: Johannes
| Hoppe
Type: New feature | Status: assigned

Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage:
returning, default, model, field | Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* owner: (none) => Johannes Hoppe
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:2>

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: Johannes
| Hoppe
Type: New feature | Status: assigned
Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage:
returning, default, model, field | Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:3>

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: Johannes
| Hoppe
Type: New feature | Status: assigned
Component: contrib.postgres | Version: master
Severity: Normal | Resolution:

Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:4>

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: Johannes
| Hoppe
Type: New feature | Status: assigned
Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:5>

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: Johannes
| Hoppe
Type: New feature | Status: assigned
Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:6>

[Django]

#29444: Allow modification of RETURNING values in django.contrib.postgres
-------------------------------------+-------------------------------------

Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned

Component: contrib.postgres | Version: master
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

* type: New feature => Cleanup/optimization

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:7>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT

-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* needs_better_patch: 0 => 1

* component: contrib.postgres => Database layer (models, ORM)

Comment:

A number of Oracle test failures remain.

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:8>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:9>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

Comment:

I fixed a couple of things. Nothing fails for me now locally that doesn't
fail on master. Can you trigger it again?

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:9>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"b131f9c79f3284f7220c65ceb9125ba4278dc0a4" b131f9c7]:
{{{
#!CommitTicketReference repository=""
revision="b131f9c79f3284f7220c65ceb9125ba4278dc0a4"
Refs #29444 -- Renamed DatabaseFeatures.can_return_id* to be generic for
other columns.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:10>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* needs_better_patch: 0 => 1

Comment:

You should be able to trigger the Oracle build yourself as described on
wiki:Jenkins. I ran the tests locally and put the failures in a PR
comment.

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:11>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:12>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:13>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:14>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* needs_better_patch: 0 => 1

* has_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:15>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:15>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:16>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"bc91f27a86090b4c688b56cd4e37f95eebe6e969" bc91f27a]:
{{{
#!CommitTicketReference repository=""
revision="bc91f27a86090b4c688b56cd4e37f95eebe6e969"
Refs #29444 -- Added support for fetching a returned non-integer insert
values on Oracle.

This is currently not actively used, since the ORM will ask the
SQL compiler to only return auto fields.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:17>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:18>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:19>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"003bb34b218adb23d1a7e67932a6ba9b3c4dcc81" 003bb34b]:
{{{
#!CommitTicketReference repository=""
revision="003bb34b218adb23d1a7e67932a6ba9b3c4dcc81"
Refs #29444 -- Made db.backends.oracle.utils.InsertVar use str as default.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:20>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: django, db, | Triage Stage: Ready for
returning, default, model, field | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:21>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Ready for
returning, default, model, field | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"736e7d44de395b867011ff9237dc5fdcfd28ee66" 736e7d44]:
{{{
#!CommitTicketReference repository=""
revision="736e7d44de395b867011ff9237dc5fdcfd28ee66"
Refs #29444 -- Fixed DateField constructor in
db.backends.oracle.utils.InsertVar.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:22>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Ready for
returning, default, model, field | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"7254f1138d9c51fa558229c39c9559b369c4278a" 7254f113]:
{{{
#!CommitTicketReference repository=""
revision="7254f1138d9c51fa558229c39c9559b369c4278a"
Refs #29444 -- Allowed returning multiple fields from INSERT statements on
PostgreSQL.

Thanks Florian Apolloner, Tim Graham, Simon Charette, Nick Pope, and
Mariusz Felisiak for reviews.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:23>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Ready for
returning, default, model, field | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* Attachment "refs-29444-oracle-part.diff" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/29444>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* has_patch: 1 => 0
* stage: Ready for checkin => Accepted

Comment:

This ticket is doable on Oracle with `cx_Oracle` 6.3+ (see
[https://blogs.oracle.com/opal/python-cx_oracle-63-supports-dml-returning-
for-batch-statement-execution cx_oracle-63-supports-dml-returning-for-
batch-statement]) that's why I'm leaving it open. First attempt of fixing
this on Oracle was a part of the original PR (see
[https://code.djangoproject.com/attachment/ticket/29444/refs-29444-oracle-
part.diff a diff]).

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:24>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/11782 PR with adding support on
Oracle]

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:25>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Johannes Hoppe):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:26>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe

Cleanup/optimization | Status: closed

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"01104368ff77c788f95377e8aceb48772a42fb42" 0110436]:
{{{
#!CommitTicketReference repository=""
revision="01104368ff77c788f95377e8aceb48772a42fb42"
Refs #29444 -- Removed redundant
DatabaseFeatures.can_return_multiple_columns_from_insert.

Unnecessary since b31e63879eb5d9717e9f890401f7222e4f00c910.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:28>

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-------------------------------------+-------------------------------------
Reporter: Johannes Hoppe | Owner: Johannes
Type: | Hoppe
Cleanup/optimization | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: django, db, | Triage Stage: Accepted
returning, default, model, field |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"b31e63879eb5d9717e9f890401f7222e4f00c910" b31e6387]:
{{{
#!CommitTicketReference repository=""
revision="b31e63879eb5d9717e9f890401f7222e4f00c910"
Fixed #29444 -- Allowed returning multiple fields from INSERT statements
on Oracle.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29444#comment:27>