[Django] #24138: Expose modelform_factory in __all__

10 views
Skip to first unread message

Django

unread,
Jan 12, 2015, 4:50:40 PM1/12/15
to django-...@googlegroups.com
#24138: Expose modelform_factory in __all__
-------------------------------+--------------------
Reporter: jschneier | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
Today I ran across the fact that `modelform_factory` is not exposed in
`__all__`/on the top level `django.forms` module. This doesn't really fit
with the rest of the documented forms api and all of the other exposed
`*factory` functions (granted they are all formsets). I think it was an
oversight that wasn't corrected when `modelform_factory` was documented in
#10239.

--
Ticket URL: <https://code.djangoproject.com/ticket/24138>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 12, 2015, 4:55:23 PM1/12/15
to django-...@googlegroups.com
#24138: Expose modelform_factory in __all__
---------------------------+---------------------------------------------
Reporter: jschneier | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------+---------------------------------------------
Changes (by collinanderson):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
* has_patch: 0 => 1
* type: Uncategorized => Bug
* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/24138#comment:1>

Django

unread,
Jan 12, 2015, 5:44:50 PM1/12/15
to django-...@googlegroups.com
#24138: Expose modelform_factory in __all__
---------------------------+---------------------------------------------
Reporter: jschneier | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------+---------------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"3844ccc958f59aef731dbb054a51fa37aa1d16ec"]:
{{{
#!CommitTicketReference repository=""
revision="3844ccc958f59aef731dbb054a51fa37aa1d16ec"
Fixed #24138 -- Added modelform_factory to __all__.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24138#comment:2>

Reply all
Reply to author
Forward
0 new messages