[Django] #23905: Use built-in email.utils.make_msgid() when dropping Python 2

7 views
Skip to first unread message

Django

unread,
Nov 24, 2014, 9:46:54 AM11/24/14
to django-...@googlegroups.com
#23905: Use built-in email.utils.make_msgid() when dropping Python 2
------------------------------------------------+--------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Mail) | Version: master
Severity: Normal | Keywords: drop-py2
Triage Stage: Someday/Maybe | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+--------------------------
`django.core.mail.message.make_msgid()` can be replaced with the Python
built-in version when we drop Python 2. In Python 3.2 the `domain`
parameter was added which is needed to accomplish the fqdn caching we are
doing.

--
Ticket URL: <https://code.djangoproject.com/ticket/23905>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 24, 2014, 2:10:36 PM11/24/14
to django-...@googlegroups.com
#23905: Use built-in email.utils.make_msgid() when dropping Python 2
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Mail) | Resolution:
Severity: Normal | Triage Stage:
Keywords: drop-py2 | Someday/Maybe

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"ebb927c4c997d4c8d9a55ec78cd2476a13bd1782"]:
{{{
#!CommitTicketReference repository=""
revision="ebb927c4c997d4c8d9a55ec78cd2476a13bd1782"
Removed workaround for lack of os.getpid() in Jython.

The Jython bug was fixed in http://bugs.jython.org/issue1518
(tested on Jython 2.7b3); also updated make_msgid() to be more like
the version in Python 3.2+; refs #23905.

Thanks Simon Charette for testing and review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23905#comment:1>

Django

unread,
Jan 19, 2017, 11:48:58 AM1/19/17
to django-...@googlegroups.com
#23905: Use built-in email.utils.make_msgid() when dropping Python 2
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: nobody

Type: Cleanup/optimization | Status: new
Component: Core (Mail) | Version: master
Severity: Normal | Resolution:
Keywords: drop-py2 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1
* stage: Someday/Maybe => Accepted


Comment:

[https://github.com/django/django/pull/7895 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/23905#comment:2>

Django

unread,
Jan 19, 2017, 12:58:39 PM1/19/17
to django-...@googlegroups.com
#23905: Use built-in email.utils.make_msgid() when dropping Python 2
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: Core (Mail) | Version: master
Severity: Normal | Resolution: fixed

Keywords: drop-py2 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by GitHub <noreply@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"9e917cc29181ad32abc21488ee70e739ce805f3a" 9e917cc2]:
{{{
#!CommitTicketReference repository=""
revision="9e917cc29181ad32abc21488ee70e739ce805f3a"
Fixed #23905, refs #23919 -- Used make_msgid() from stdlib.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23905#comment:3>

Reply all
Reply to author
Forward
0 new messages