[Django] #25439: Add `SUCCESS` style to termcolor palettes
Django
-------------------------+-------------------------------------------------
Reporter: | Owner: nobody
Deacalion |
Type: New | Status: new
feature |
Component: | Version: 1.8
Utilities |
Severity: Normal | Keywords: termcolor termcolour colors colours
Triage Stage: | Has patch: 0
Unreviewed |
Easy pickings: 0 | UI/UX: 0
-------------------------+-------------------------------------------------
I've just created a management command that shows if something was
successful or whether an error was encountered trying to perform the task.
I looked at the palettes in "django/utils/termcolors.py" to find a bold
red for displaying the error and found it was called "ERROR".
However, the only bold green style I found was "MIGRATE_SUCCESS", but it
feels odd using this in my management command since it has nothing to do
with migrations.
Could I add a generic "SUCCESS" style that is the same as
"MIGRATE_SUCCESS" or should these styles not be used by third party
management commands?
--
Ticket URL: <https://code.djangoproject.com/ticket/25439>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Deacalion | Owner: nobody
Type: New feature | Status: new
Component: Utilities | Version: 1.8
Severity: Normal | Resolution:
Keywords: termcolor termcolour colors colours | Triage Stage:
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------------+-------------------------
Changes (by Deacalion):
* Attachment "termcolor-styles.png" added.
Management command termcolors
Django
Reporter: Deacalion | Owner: nobody
Type: New feature | Status: new
Component: Utilities | Version: 1.8
Severity: Normal | Resolution:
termcolour colors colours | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Deacalion):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> I've just created a management command that shows if something was
> successful or whether an error was encountered trying to perform the
> task. I looked at the palettes in "django/utils/termcolors.py" to find a
> bold red for displaying the error and found it was called "ERROR".
>
> However, the only bold green style I found was "MIGRATE_SUCCESS", but it
> feels odd using this in my management command since it has nothing to do
> with migrations.
>
> Could I add a generic "SUCCESS" style that is the same as
> "MIGRATE_SUCCESS" or should these styles not be used by third party
> management commands?
New description:
I've just created a management command that shows if something was
successful or whether an error was encountered trying to perform the task.
I looked at the palettes in "django/utils/termcolors.py" to find a bold
red for displaying the error and found it was called "ERROR".
However, the only bold green style I found was "MIGRATE_SUCCESS", but it
feels odd using this in my management command since it has nothing to do
with migrations.
Could I add a generic "SUCCESS" style that is the same as
"MIGRATE_SUCCESS" or should these styles not be used by third party
management commands?
Edit: added a screencap of all the styles.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/25439#comment:1>
Django
Reporter: Deacalion | Owner: nobody
Type: New feature | Status: new
Component: Utilities | Version: 1.8
Severity: Normal | Resolution:
termcolour colors colours |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by claudep):
* stage: Unreviewed => Accepted
Comment:
Looks like a generic SUCCESS style would be a nice addition.
--
Ticket URL: <https://code.djangoproject.com/ticket/25439#comment:2>
Django
Reporter: Deacalion | Owner: nobody
Type: New feature | Status: new
Component: Utilities | Version: 1.8
Severity: Normal | Resolution:
Keywords: termcolor | Triage Stage: Accepted
termcolour colors colours |
Needs tests: 0 | Patch needs improvement: 0
Changes (by Deacalion):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25439#comment:3>
Django
Reporter: Deacalion | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: termcolor | Triage Stage: Ready for
termcolour colors colours | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by claudep):
* version: 1.8 => master
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25439#comment:4>
Django
Reporter: Deacalion | Owner: nobody
Component: Utilities | Version: master
Severity: Normal | Resolution: fixed
Keywords: termcolor | Triage Stage: Ready for
termcolour colors colours | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"f06ce6053cae6a96ecce29ce2020789945757bf4" f06ce605]:
{{{
#!CommitTicketReference repository=""
revision="f06ce6053cae6a96ecce29ce2020789945757bf4"
Fixed #25439 -- Added `SUCCESS` style to termcolor palettes
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25439#comment:5>