[Django] #24388: Drop django.utils._os.rmtree_errorhandler

9 views
Skip to first unread message

Django

unread,
Feb 22, 2015, 4:10:13 AM2/22/15
to django-...@googlegroups.com
#24388: Drop django.utils._os.rmtree_errorhandler
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
When Django was maintained with SVN, `collectstatic` could copy the `.svn`
directory inside each directory (e.g. when testing
`use_default_ignore_patterns=False`). Removing these directories was a
problem on Windows. [d18d37ce] introduced `rmtree_errorhandler` to solve
that problem.

Since we've moved to git, there's a single `.git` directory at the root of
the repository and we don't need that anymore.

[a9a0f0b0] also used `rmtree_errorhandler` in `startproject`/`startapp`.
It's a large commit. I couldn't find anything about `rmtree_errorhandler`
in the ticket, in the code or in the tests. I assume it was included for
extra safety.

--
Ticket URL: <https://code.djangoproject.com/ticket/24388>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 22, 2015, 10:05:25 AM2/22/15
to django-...@googlegroups.com
#24388: Drop django.utils._os.rmtree_errorhandler
--------------------------------------+------------------------------------

Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/24388#comment:1>

Django

unread,
Feb 27, 2015, 2:49:03 PM2/27/15
to django-...@googlegroups.com
#24388: Drop django.utils._os.rmtree_errorhandler
--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Utilities | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):

* status: new => closed
* resolution: => fixed


Comment:

Removal applied in c688460df6239539d2b5a1fc8c51778086fe7c35.

--
Ticket URL: <https://code.djangoproject.com/ticket/24388#comment:2>

Reply all
Reply to author
Forward
0 new messages