[Django] #26474: Add source of minified javascript files
Django
--------------------------------------+--------------------
Reporter: rhertzog | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
In Debian, we like to have the sources of everything that we ship and we
consider that minified javascript files are not really scripts (which are
their own source).
There are currently two problematic files in Django:
js_tests/qunit/blanket.min.js
django/contrib/admin/static/admin/js/vendor/xregexp/xregexp.min.js
To remedy this I would suggest to either:
- directly use a non-minified file like you do for many other javascript
files (ex: django/contrib/admin/static/admin/js/SelectFilter2.js)
- store a non-minified file next to the minified file (same name without
the ".min" part)
Thank you for considering this request.
--
Ticket URL: <https://code.djangoproject.com/ticket/26474>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: rhertzog | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Uncategorized | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
I've asked for thoughts about this on the
[https://groups.google.com/d/topic/django-
developers/_-3FBN6-t_0/discussion django-developers] mailing list.
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:1>
Django
Reporter: rhertzog | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* component: Uncategorized => Packaging
* stage: Unreviewed => Accepted
Comment:
We can add the non-minified versions I guess. This would also include
modifying `django/contrib/admin/options.py` to use `extra` in
`vendor/xregexp/xregexp.min.js`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:2>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by knightrix):
* status: new => assigned
* owner: nobody => knightrix
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:3>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by knightrix):
I've created [https://github.com/django/django/pull/6724 PR 6724]
The added source file xregexp.js did not pass js check. It was downloaded
directly from the original repo. I am not familiar with the process. Am I
supposed to update the source js file to make it pass? Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:4>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"054e74420b7a31bac67d4993b462eea7b9b7a5ba" 054e7442]:
{{{
#!CommitTicketReference repository=""
revision="054e74420b7a31bac67d4993b462eea7b9b7a5ba"
Refs #16501, #26474 -- Added xregexp.js source file.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:5>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"8f8dc830dfeb321b0de3325a8d2c859fdc20c3af" 8f8dc830]:
{{{
#!CommitTicketReference repository=""
revision="8f8dc830dfeb321b0de3325a8d2c859fdc20c3af"
Refs #26474, DEP 0003 -- Added blanket.js source file.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:6>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a9b0b0762fafff3ad9e6df56e781f84ec811c68f" a9b0b07]:
{{{
#!CommitTicketReference repository=""
revision="a9b0b0762fafff3ad9e6df56e781f84ec811c68f"
[1.10.x] Refs #26474, DEP 0003 -- Added blanket.js source file.
Backport of 8f8dc830dfeb321b0de3325a8d2c859fdc20c3af from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:8>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"ef93af919b557563e678ec0f9fb507bd2c6768d9" ef93af91]:
{{{
#!CommitTicketReference repository=""
revision="ef93af919b557563e678ec0f9fb507bd2c6768d9"
[1.10.x] Refs #16501, #26474 -- Added xregexp.js source file.
Backport of 054e74420b7a31bac67d4993b462eea7b9b7a5ba from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:7>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"307de7d9e80e1148685b981eede0bd2fdbe91d46" 307de7d9]:
{{{
#!CommitTicketReference repository=""
revision="307de7d9e80e1148685b981eede0bd2fdbe91d46"
[1.9.x] Refs #16501, #26474 -- Added xregexp.js source file.
Backport of 054e74420b7a31bac67d4993b462eea7b9b7a5ba from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:10>
Django
Reporter: rhertzog | Owner: knightrix
Type: | Status: assigned
Cleanup/optimization |
Component: Packaging | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"36b9e4ab4d188d1adb8167e39a4bda82a957cbc5" 36b9e4a]:
{{{
#!CommitTicketReference repository=""
revision="36b9e4ab4d188d1adb8167e39a4bda82a957cbc5"
[1.9.x] Refs #26474, DEP 0003 -- Added blanket.js source file.
Backport of 8f8dc830dfeb321b0de3325a8d2c859fdc20c3af from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:9>
Django
Reporter: rhertzog | Owner: knightrix
Cleanup/optimization |
Component: Packaging | Version: 1.9
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: assigned => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/26474#comment:11>