--
Ticket URL: <https://code.djangoproject.com/ticket/20691>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* cc: timograham@… (added)
* needs_better_patch: => 0
* needs_tests: => 0
* version: 1.5 => master
* needs_docs: => 0
* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:1>
* needs_better_patch: 0 => 1
Comment:
I think I would have written a note at the start of the subsection: `If
you are on Python 3, you can skip this section because you'll always
create __str__()...`. This can prevent a Python 3 user to read the
paragraph just to finally realize that he's not concerned.
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:2>
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:3>
* stage: Accepted => Ready for checkin
Comment:
LVGTM :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:4>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"8a679386c3924026f8558f9cd0164890a9461e2c"]:
{{{
#!CommitTicketReference repository=""
revision="8a679386c3924026f8558f9cd0164890a9461e2c"
Fixed #20691 -- Added a note for __str__() vs. __unicode__() and Python 3.
Thanks garrison for the suggestion.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:5>
Comment (by Tim Graham <timograham@…>):
In [changeset:"b36f55c5a5bc7e3dac8a811973c7f7ad1c92d7c5"]:
{{{
#!CommitTicketReference repository=""
revision="b36f55c5a5bc7e3dac8a811973c7f7ad1c92d7c5"
[1.6.x] Fixed #20691 -- Added a note for __str__() vs. __unicode__() and
Python 3.
Thanks garrison for the suggestion.
Backport of 8a679386c3 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:6>
Comment (by Tim Graham <timograham@…>):
In [changeset:"4453d8651af4579b3b83d873cadbda0707b7ab2a"]:
{{{
#!CommitTicketReference repository=""
revision="4453d8651af4579b3b83d873cadbda0707b7ab2a"
[1.5.x] Fixed #20691 -- Added a note for __str__() vs. __unicode__() and
Python 3.
Thanks garrison for the suggestion.
Backport of 8a679386c3 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20691#comment:7>