[Django] #33452: Save buttons in admin are too close together on medium screen sizes

5 views
Skip to first unread message

Django

unread,
Jan 19, 2022, 4:22:23 PM1/19/22
to django-...@googlegroups.com
#33452: Save buttons in admin are too close together on medium screen sizes
-----------------------------------------+------------------------
Reporter: David Smith | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
The save buttons on the admin wrap and become very squashed on "medium"
screen sizes.

--
Ticket URL: <https://code.djangoproject.com/ticket/33452>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 19, 2022, 4:23:16 PM1/19/22
to django-...@googlegroups.com
#33452: Save buttons in admin are too close together on medium screen sizes
-------------------------------+--------------------------------------

Reporter: David Smith | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by David Smith):

* Attachment "2022-01-19_21-22.png" added.

Save buttons in the admin.

Django

unread,
Jan 19, 2022, 11:43:08 PM1/19/22
to django-...@googlegroups.com
#33452: Save buttons in admin are too close together on medium screen sizes
--------------------------------------+------------------------------------

Reporter: David Smith | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* cc: Tom Carrick (added)
* component: Uncategorized => contrib.admin
* ui_ux: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


Old description:

> The save buttons on the admin wrap and become very squashed on "medium"
> screen sizes.

New description:

The save buttons on the admin wrap and become very squashed on "medium"

screen sizes when the navigation sidebar is on.

--

Comment:

Thanks for the report. It's caused by the navigation sidebar.

Regression in d24ba1be7a53a113d19e2860c03aff9922efec24.

--
Ticket URL: <https://code.djangoproject.com/ticket/33452#comment:1>

Django

unread,
Jan 27, 2022, 4:41:50 AM1/27/22
to django-...@googlegroups.com
#33452: Save buttons in admin are too close together on medium screen sizes
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: swapnil
Type: | shinde
Cleanup/optimization | Status: assigned

Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by swapnil shinde):

* owner: nobody => swapnil shinde
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/33452#comment:2>

Django

unread,
Jan 28, 2022, 2:43:22 AM1/28/22
to django-...@googlegroups.com
#33452: Save buttons in admin are too close together on medium screen sizes
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: swapnil
Type: | shinde
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/15373 Alternative PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33452#comment:3>

Django

unread,
Jan 29, 2022, 5:59:51 AM1/29/22
to django-...@googlegroups.com
#33452: Save buttons in admin are too close together on medium screen sizes
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: swapnil
Type: | shinde
Cleanup/optimization | Status: closed
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"67db54a5a7e0f1c2aa395e1db51214d09ae41f3f" 67db54a5]:
{{{
#!CommitTicketReference repository=""
revision="67db54a5a7e0f1c2aa395e1db51214d09ae41f3f"
Fixed #33452 -- Fixed admin change-form layout for submit buttons on mid-
sized displays.

Thanks David Smith for reviews.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33452#comment:4>

Reply all
Reply to author
Forward
0 new messages