[Django] #23875: Clean up Query.get_count() implementation

10 views
Skip to first unread message

Django

unread,
Nov 20, 2014, 5:33:57 AM11/20/14
to django-...@googlegroups.com
#23875: Clean up Query.get_count() implementation
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database | Keywords:
layer (models, ORM) | Has patch: 1
Severity: Normal | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
The Query.get_count() implementation can be significantly cleaned up. I
believe get_count()/add_count_column() was implemented before aggregation
support. We can now get rid of this code.

--
Ticket URL: <https://code.djangoproject.com/ticket/23875>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 21, 2014, 9:05:10 AM11/21/14
to django-...@googlegroups.com
#23875: Clean up Query.get_count() implementation
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/23875#comment:1>

Django

unread,
Nov 27, 2014, 6:27:27 AM11/27/14
to django-...@googlegroups.com
#23875: Clean up Query.get_count() implementation
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Database layer | Resolution: fixed

(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"c7fd9b242d2d63406f1de6cc3204e35aaa025233"]:
{{{
#!CommitTicketReference repository=""
revision="c7fd9b242d2d63406f1de6cc3204e35aaa025233"
Fixed #23875 -- cleaned up query.get_count()
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23875#comment:2>

Reply all
Reply to author
Forward
0 new messages