[Django] #28688: Unicode slugs are not properly slugified due to javascript limitations
Django
--------------------------------------------------+------------------------
Reporter: Sævar Öfjörð Magnússon | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------------+------------------------
When using unicode slugs, and the slug contains a unicode character and a
word from the removelist in urlify.js right after it (e.g. the letter
"a"), the unicode character is detected as a word boundary in javascript
and the text that matches the removelist is stripped from the slug...
The removelist contains the following words:
var removelist = [
"a", "an", "as", "at", "before", "but", "by", "for", "from", "is",
"in", "into", "like", "of", "off", "on", "onto", "per", "since",
"than", "the", "this", "that", "to", "up", "via", "with"
];
And when I try to slugify this text: "Kaupa miða"
The result becomes: "kaupa-mið"
This can be tested using the following line in console:
URLify("Kaupa miða", 255, true)
(only when urlify.js is loaded, of course)
--
Ticket URL: <https://code.djangoproject.com/ticket/28688>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Sævar Öfjörð | Owner: nobody
Magnússon |
Type: Bug | Status: new
Component: contrib.admin | Version: 1.11
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:1>
Django
Reporter: Sævar Öfjörð | Owner: nobody
Magnússon |
Component: contrib.admin | Version: 1.11
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
The solution could be to check if the string contains any non-ASCII char
and simply skip the `removelist` removal, as the language is probably not
English in that case.
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:2>
Django
Reporter: Sævar Öfjörð | Owner: Sævar
Magnússon | Öfjörð Magnússon
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Sævar Öfjörð Magnússon):
* owner: nobody => Sævar Öfjörð Magnússon
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:3>
Django
Reporter: Sævar Öfjörð | Owner: Sævar
Magnússon | Öfjörð Magnússon
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Sævar Öfjörð Magnússon):
* has_patch: 0 => 1
Comment:
Pull request: https://github.com/django/django/pull/9219
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:4>
Django
Reporter: Sævar Öfjörð | Owner: Sævar
Magnússon | Öfjörð Magnússon
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:5>
Django
Reporter: Sævar Öfjörð | Owner: Sævar
Magnússon | Öfjörð Magnússon
Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f90be0a83ef5aa333b19e259faab73ee117d5339" f90be0a8]:
{{{
#!CommitTicketReference repository=""
revision="f90be0a83ef5aa333b19e259faab73ee117d5339"
Fixed #28688 -- Made admin's URLify.js skip removal of English words if
non-ASCII chars are present.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:6>
Django
Reporter: Sævar Öfjörð | Owner: Sævar
Magnússon | Öfjörð Magnússon
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"8b9a163afa553ee9d57febae69c9eb0c88259012" 8b9a163]:
{{{
#!CommitTicketReference repository=""
revision="8b9a163afa553ee9d57febae69c9eb0c88259012"
Refs #28688 -- Updated a selenium test for admin's URLify.js change.
English words aren't removed if non-ASCII chars are present.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28688#comment:7>