[Django] #26153: Allow get_extra_descriptor_filter to return Q-objects
Django
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: 1.9
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
In django 1.8 it was possible to return Q-objects from
ForeignObject.get_extra_descriptor_filter(). In Django 1.9 the return
value must be a dictionary.
The problem is that in Django 1.9 it is impossible to return an OR
combined condition. While the get_extra_descriptor_filter() is private API
I'd like to maintain the ability to return Q-objects. This is
straightforward patch with little regression risks.
--
Ticket URL: <https://code.djangoproject.com/ticket/26153>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/26153#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26153#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Component: Database layer | Version: 1.9
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"353aecbf8c1a8cc6f3985149e2895d49e53dfc1c" 353aecbf]:
{{{
#!CommitTicketReference repository=""
revision="353aecbf8c1a8cc6f3985149e2895d49e53dfc1c"
Fixed #26153 -- Reallowed Q-objects in
ForeignObject.get_extra_descriptor_filter().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26153#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: akaariai | Owner: nobody
Component: Database layer | Version: 1.9
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"25496f0f7b953b9bca709ab20bc536137f57402d" 25496f0f]:
{{{
#!CommitTicketReference repository=""
revision="25496f0f7b953b9bca709ab20bc536137f57402d"
[1.9.x] Fixed #26153 -- Reallowed Q-objects in
ForeignObject.get_extra_descriptor_filter().
Backport of 353aecbf8c1a8cc6f3985149e2895d49e53dfc1c from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26153#comment:4>