[Django] #29677: StaticFilesStorage.post_process does not seem to exist, contrary to documentation

5 views
Skip to first unread message

Django

unread,
Aug 15, 2018, 1:02:39 PM8/15/18
to django-...@googlegroups.com
#29677: StaticFilesStorage.post_process does not seem to exist, contrary to
documentation
-----------------------------------------+------------------------
Reporter: Atul Varma | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
The
[https://docs.djangoproject.com/en/2.1/ref/contrib/staticfiles/#django.contrib.staticfiles.storage.StaticFilesStorage.post_process
documentation for this method] states that "This method is called by the
collectstatic management command after each run and gets passed the local
storages and paths of found files as a dictionary, as well as the command
line options."

However, as far as I can tell, this method does not seem to actually
exist. I thought perhaps it might be defined on one of its ancestor
classes, but it doesn't seem to be... am I mistaken, or is this some kind
of method that's optionally implementable by subclasses or something?

Apologies if this is the wrong place to bring this up, or if I am simply
confused and do not understand what is going on.

--
Ticket URL: <https://code.djangoproject.com/ticket/29677>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 15, 2018, 3:49:36 PM8/15/18
to django-...@googlegroups.com
#29677: StaticFilesStorage.post_process does not seem to exist, contrary to
documentation
--------------------------------------+------------------------------------

Reporter: Atul Varma | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* component: Uncategorized => Documentation
* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

Adding "If this method is defined on a storage, ..." might be enough
clarification? [https://github.com/django/django/pull/10300 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/29677#comment:1>

Django

unread,
Aug 16, 2018, 4:38:04 AM8/16/18
to django-...@googlegroups.com
#29677: StaticFilesStorage.post_process does not seem to exist, contrary to
documentation
--------------------------------------+------------------------------------

Reporter: Atul Varma | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson <carlton.gibson@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"7f6b013bf60e6168a7e0a8f2b97954c3a45725e0" 7f6b013b]:
{{{
#!CommitTicketReference repository=""
revision="7f6b013bf60e6168a7e0a8f2b97954c3a45725e0"
Fixed #29677 -- Doc'd return value of StaticFilesStorage.post_process().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29677#comment:2>

Django

unread,
Aug 16, 2018, 4:40:43 AM8/16/18
to django-...@googlegroups.com
#29677: StaticFilesStorage.post_process does not seem to exist, contrary to
documentation
--------------------------------------+------------------------------------

Reporter: Atul Varma | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Carlton Gibson <carlton.gibson@…>):

In [changeset:"5628a8a23f462229a6511aa9d7875efae8ae54d5" 5628a8a2]:
{{{
#!CommitTicketReference repository=""
revision="5628a8a23f462229a6511aa9d7875efae8ae54d5"
[2.1.x] Fixed #29677 -- Doc'd return value of
StaticFilesStorage.post_process().

Backport of 7f6b013bf60e6168a7e0a8f2b97954c3a45725e0 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29677#comment:3>

Reply all
Reply to author
Forward
0 new messages