[Django] #27345: Stop setting the Date header in ConditionalGetMiddleware

3 views
Skip to first unread message

Django

unread,
Oct 14, 2016, 12:25:24 AM10/14/16
to django-...@googlegroups.com
#27345: Stop setting the Date header in ConditionalGetMiddleware
-----------------------------------------+--------------------
Reporter: Kevin Christopher Henry | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------------+--------------------
This code, dating back to 2005, doesn't seem to serve any purpose at this
time. The `Date` header is actually required on all responses, and will be
provided by the server. This is the only place in the code base where the
`Date` header is used.

This is documented behavior, but I think it can be removed without a
deprecation cycle since any affected response will continue to have a
`Date` header set by the server.

--
Ticket URL: <https://code.djangoproject.com/ticket/27345>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 14, 2016, 8:05:05 AM10/14/16
to django-...@googlegroups.com
#27345: Stop setting the Date header in ConditionalGetMiddleware
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: nobody
Henry |
Type: | Status: new
Cleanup/optimization |

Component: HTTP handling | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: => 0
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0


Comment:

Seems okay to me. [https://github.com/django/django/pull/7392 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27345#comment:1>

Django

unread,
Oct 14, 2016, 1:32:02 PM10/14/16
to django-...@googlegroups.com
#27345: Stop setting the Date header in ConditionalGetMiddleware
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: nobody
Henry |
Type: | Status: closed
Cleanup/optimization |

Component: HTTP handling | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"61f9243e5138b79f2671936b4f55941cd02da89e" 61f9243]:
{{{
#!CommitTicketReference repository=""
revision="61f9243e5138b79f2671936b4f55941cd02da89e"
Fixed #27345 -- Stopped setting the Date header in
ConditionalGetMiddleware.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27345#comment:2>

Reply all
Reply to author
Forward
0 new messages