[Django] #33094: "Show all" is ambiguous
Django
------------------------------------------+------------------------
Reporter: Richard Laager | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
The admin interface used "Show all" with two different meanings. One is to
disable pagination (a query string of ?all=). The other is to disable
filters (a query string of ?), when show_full_result_count is False.
I propose changing the latter to "Clear search" and have submitted a PR
here:
https://github.com/django/django/pull/14844
--
Ticket URL: <https://code.djangoproject.com/ticket/33094>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Richard Laager | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* Attachment "Screenshot_20210909_065351.png" added.
Django
Reporter: Richard Laager | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: Carlton Gibson (added)
* status: new => closed
* resolution: => wontfix
* type: Bug => Cleanup/optimization
Comment:
IMO, ''"Show all"'' is more accurate, because it also clears filters, not
only ''"Search"''. Also, ''"Show all"'' links appear in different places
which makes them sufficiently distinguishable:
[[Image(Screenshot_20210909_065351.png)]]
It's also
[https://docs.djangoproject.com/en/3.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.show_full_result_count
documented].
--
Ticket URL: <https://code.djangoproject.com/ticket/33094#comment:1>
Django
Reporter: Richard Laager | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Richard Laager):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33094#comment:2>
Django
Reporter: Richard Laager | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Richard Laager):
Fair enough. I didn't realize it cleared filters too.
Part of my motivation here is that I'm upgrading from an old version of
Django. It showed the pagination at the top of the page too, so there was
a "Show all" link near the top of the page previously, and there is now,
but they have different behaviors. I didn't expect this argument to carry
much weight at this point, though, as people should be through this change
already if they're staying on supported versions.
I closed the associated PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/33094#comment:3>