[Django] #25586: Admin's tabular inline fields may be misaligned if the first form field is hidden

10 views
Skip to first unread message

Django

unread,
Oct 21, 2015, 10:17:20 AM10/21/15
to django-...@googlegroups.com
#25586: Admin's tabular inline fields may be misaligned if the first form field is
hidden
-----------------------------------------+------------------------
Reporter: blueyed | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
If the first form field in a tabular inline is hidden, the first <th>
won't have colspan=2 which is meant to account for the first <td
class="original"> which doesn't have a corresponding <th>. This will cause
the table cells to be misaligned. More details on the
[https://github.com/django/django/pull/5445 pull request].

--
Ticket URL: <https://code.djangoproject.com/ticket/25586>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 21, 2015, 10:18:34 AM10/21/15
to django-...@googlegroups.com
#25586: Admin's tabular inline fields may be misaligned if the first form field is
hidden
-------------------------------------+-------------------------------------

Reporter: blueyed | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25586#comment:1>

Django

unread,
Oct 21, 2015, 10:26:55 AM10/21/15
to django-...@googlegroups.com
#25586: Admin's tabular inline fields may be misaligned if the first form field is
hidden
-------------------------------------+-------------------------------------
Reporter: blueyed | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"1745aa000a4e859c21270371662634978371dda8" 1745aa0]:
{{{
#!CommitTicketReference repository=""
revision="1745aa000a4e859c21270371662634978371dda8"
Fixed #25586 -- Fixed possible table cell misalignment in admin's tabular
inlines.

The table body (tbody) was shifted by one column to the left
if the first inline form field is hidden.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25586#comment:2>

Reply all
Reply to author
Forward
0 new messages