[Django] #25524: Evaluate handle_spheroid removal in get_distance method

40 views
Skip to first unread message

Django

unread,
Oct 7, 2015, 12:34:42 PM10/7/15
to django-...@googlegroups.com
#25524: Evaluate handle_spheroid removal in get_distance method
------------------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords: 2.0
Triage Stage: Someday/Maybe | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
While fixing #25499, I had to keep duplicate handling of the 'spheroid'
parameter for distance lookups (PostGISOperations), in the
`get_distance()` method and in the `PostGISDistanceOperator` class. This
is because `get_distance` is also called from the `GeoQuerySet` class
which might be mostly obsolete or even removed in Django 2.0.

This ticket is a reminder to check and if possible remove the 'spheroid'
handling in `PostGISOperations.get_distance()` in Django 2.0.

--
Ticket URL: <https://code.djangoproject.com/ticket/25524>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 10, 2017, 7:50:48 PM2/10/17
to django-...@googlegroups.com
#25524: Evaluate handle_spheroid removal in get_distance method
--------------------------------------+------------------------------------
Reporter: Claude Paroz | Owner: nobody

Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: 2.0 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1
* stage: Someday/Maybe => Accepted


Comment:

[https://github.com/django/django/pull/8049 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/25524#comment:1>

Django

unread,
Feb 11, 2017, 5:45:56 AM2/11/17
to django-...@googlegroups.com
#25524: Evaluate handle_spheroid removal in get_distance method
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: 2.0 | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25524#comment:2>

Django

unread,
Feb 11, 2017, 5:47:30 AM2/11/17
to django-...@googlegroups.com
#25524: Evaluate handle_spheroid removal in get_distance method
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution: fixed

Keywords: 2.0 | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"0166dd2f8c54b62a65735c395825b66eeb39788c" 0166dd2f]:
{{{
#!CommitTicketReference repository=""
revision="0166dd2f8c54b62a65735c395825b66eeb39788c"
Fixed #25524 -- Removed GISOperations.get_distance()'s handle_spheroid
param.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25524#comment:3>

Reply all
Reply to author
Forward
0 new messages