[Django] #30779: technical_500.html: use filename:lineno format for exception location
Django
------------------------------------------------+------------------------
Reporter: Daniel Hahler | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Using
{{{
Exception Location: …/dj/views.py:28 (in form_valid)
}}}
instead of
{{{
Exception Location: …/dj/views.py in form_valid, line 28
}}}
would allow for easier copy'n'paste of the location for going there in an
editor.
The format ``fname:lnum`` is usually handled there to go to the line
number there directly.
By default this does not work as good as it could then, since browsers
will not include the ":" on double-click (tested Firefox and qutebrowser),
but the "text-select" CSS property can be used for this, which then
selected it with a single click already. Ref:
https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
--
Ticket URL: <https://code.djangoproject.com/ticket/30779>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Daniel Hahler | Owner: (none)
Cleanup/optimization |
Component: Error reporting | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Daniel Hahler):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Old description:
> Using
> {{{
> Exception Location: …/dj/views.py:28 (in form_valid)
> }}}
>
> instead of
> {{{
> Exception Location: …/dj/views.py in form_valid, line 28
> }}}
>
> would allow for easier copy'n'paste of the location for going there in an
> editor.
>
> The format ``fname:lnum`` is usually handled there to go to the line
> number there directly.
>
> By default this does not work as good as it could then, since browsers
> will not include the ":" on double-click (tested Firefox and
> qutebrowser), but the "text-select" CSS property can be used for this,
> which then selected it with a single click already. Ref:
> https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
New description:
Using
{{{
Exception Location: …/dj/views.py:28 (in form_valid)
}}}
instead of
{{{
Exception Location: …/dj/views.py in form_valid, line 28
}}}
would allow for easier copy'n'paste of the location for going there in an
editor.
The format ``fname:lnum`` is usually handled there to go to the line
number there directly.
By default this does not work as good as it could then, since browsers
will not include the ":" on double-click (tested Firefox and qutebrowser),
but the "text-select" CSS property can be used for this, which then
selected it with a single click already. Ref:
https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
https://github.com/django/django/pull/11789
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:1>
Django
Reporter: Daniel Hahler | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
Hey Daniel. Yes, sounds like a nice gain. I am certainly happy to review a
PR on it. :) Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:2>
Django
Reporter: Daniel Hahler | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Daniel Hahler):
Thanks Carlton.
Please see https://github.com/django/django/pull/11789 then.
It probably only needs test adjustments, which I'd like to do only in the
end.
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:3>
Django
Reporter: Daniel Hahler | Owner: vinayak-
Type: | sharda
Cleanup/optimization | Status: assigned
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by vinayak-sharda):
* owner: (none) => vinayak-sharda
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:4>
Django
Reporter: Daniel Hahler | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by vinayak-sharda):
* owner: vinayak-sharda => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:5>
Django
Reporter: Daniel Hahler | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Hasan Ramezani):
* cc: Hasan Ramezani (added)
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:4>
Django
Reporter: Daniel Hahler | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by felixxm:
Old description:
> Using
> {{{
> Exception Location: …/dj/views.py:28 (in form_valid)
> }}}
>
> instead of
> {{{
> Exception Location: …/dj/views.py in form_valid, line 28
> }}}
>
> would allow for easier copy'n'paste of the location for going there in an
> editor.
>
> The format ``fname:lnum`` is usually handled there to go to the line
> number there directly.
>
> By default this does not work as good as it could then, since browsers
> will not include the ":" on double-click (tested Firefox and
> qutebrowser), but the "text-select" CSS property can be used for this,
> which then selected it with a single click already. Ref:
> https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
>
> https://github.com/django/django/pull/11789
New description:
Using
{{{
Exception Location: …/dj/views.py, line 28, in form_valid
}}}
instead of
{{{
Exception Location: …/dj/views.py in form_valid, line 28
}}}
would allow for easier copy'n'paste of the location for going there in an
editor.
~~The format ``fname:lnum`` is usually handled there to go to the line
number there directly.~~
By default this does not work as good as it could then, since browsers
will not include the ":" on double-click (tested Firefox and qutebrowser),
but the "text-select" CSS property can be used for this, which then
selected it with a single click already. Ref:
https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
https://github.com/django/django/pull/11789
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:5>
Django
Reporter: Daniel Hahler | Owner: Mariusz
Type: | Felisiak <felisiak.mariusz@…>
Cleanup/optimization | Status: closed
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* owner: (none) => Mariusz Felisiak <felisiak.mariusz@…>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"377018b6ffc259806c7aab11e965b1e8e7049e50" 377018b6]:
{{{
#!CommitTicketReference repository=""
revision="377018b6ffc259806c7aab11e965b1e8e7049e50"
Fixed #30779 -- Improved selection of filenames in technical 500 debug
page.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30779#comment:6>