[Django] #28411: Use cx_Oracle.Cursor.outputtypehandler instead of _rowfactory().

8 views
Skip to first unread message

Django

unread,
Jul 18, 2017, 1:19:43 PM7/18/17
to django-...@googlegroups.com
#28411: Use cx_Oracle.Cursor.outputtypehandler instead of _rowfactory().
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords: Oracle
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I propose to use [http://cx-
oracle.readthedocs.io/en/latest/cursor.html#Cursor.outputtypehandler
cx_Oracle.Cursor.outputtypehandler] instead of the internal
[https://github.com/django/django/blob/master/django/db/backends/oracle/base.py#L527-L563
_rowfactory()] method. It should also simplify
[https://github.com/django/django/blob/master/django/db/backends/oracle/base.py#L381
FormatStylePlaceholderCursor].

--
Ticket URL: <https://code.djangoproject.com/ticket/28411>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 18, 2017, 2:01:02 PM7/18/17
to django-...@googlegroups.com
#28411: Use cx_Oracle.Cursor.outputtypehandler instead of _rowfactory().
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28411#comment:1>

Django

unread,
Jul 18, 2017, 2:35:29 PM7/18/17
to django-...@googlegroups.com
#28411: Use cx_Oracle.Cursor.outputtypehandler instead of _rowfactory().
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8781 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28411#comment:2>

Django

unread,
Jul 18, 2017, 3:20:56 PM7/18/17
to django-...@googlegroups.com
#28411: Use cx_Oracle.Cursor.outputtypehandler instead of _rowfactory().
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: Oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28411#comment:3>

Django

unread,
Jul 19, 2017, 2:43:13 AM7/19/17
to django-...@googlegroups.com
#28411: Use cx_Oracle.Cursor.outputtypehandler instead of _rowfactory().
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: Oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e06cab260049bb58eafdc4f60ac50a5f3759c38c" e06cab2]:
{{{
#!CommitTicketReference repository=""
revision="e06cab260049bb58eafdc4f60ac50a5f3759c38c"
Fixed #28411 -- Used cx_Oracle.Cursor.outputtypehandler instead of
_rowfactory() on Oracle.

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28411#comment:4>

Reply all
Reply to author
Forward
0 new messages