[Django] #24152: Deprecate GeoQuerySet aggregate methods
Django
------------------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
In the trend of making `GeoQuerySet` as similar to `QuerySet` as possible,
I'd suggest to deprecate the `GeoQuerySet` aggregation methods, as GIS
aggregates (`Union`, `Extent`, `Extent3D`, `MakeLine`, `Collect`) are
already available and usable like any other Django aggregate.
--
Ticket URL: <https://code.djangoproject.com/ticket/24152>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* needs_docs: 0 => 1
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/3920
I've not updated the documentation yet. Should this deprecation happen in
1.8 or are we too late?
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:1>
Django
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
As it's not a new feature, I'm fine with it going in tomorrow.
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:2>
Django
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"a34fba5e596a3ec95bf284fd77b1609e71a65019"]:
{{{
#!CommitTicketReference repository=""
revision="a34fba5e596a3ec95bf284fd77b1609e71a65019"
Simplified a bit GeoAggregate classes
Thanks Josh Smeaton for the review. Refs #24152.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:3>
Django
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:4>
Django
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"a79e6b67175f532049967268c10609af6d31d140"]:
{{{
#!CommitTicketReference repository=""
revision="a79e6b67175f532049967268c10609af6d31d140"
Fixed #24152 -- Deprecated GeoQuerySet aggregate methods
Thanks Josh Smeaton and Tim Graham for the reviews.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:5>
Django
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a8eb715b663ff836e54f04c0e4fcafa2ee468b4e" a8eb715]:
{{{
#!CommitTicketReference repository=""
revision="a8eb715b663ff836e54f04c0e4fcafa2ee468b4e"
Refs #24152 -- Fixed typos in deprecated GeoQuerySet aggregate names.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:6>
Django
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"6acf0df86255ef4d2097f24cbfa39fdb44de19e3" 6acf0df8]:
{{{
#!CommitTicketReference repository=""
revision="6acf0df86255ef4d2097f24cbfa39fdb44de19e3"
[1.8.x] Refs #24152 -- Fixed typos in deprecated GeoQuerySet aggregate
names.
Backport of a8eb715b663ff836e54f04c0e4fcafa2ee468b4e from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:7>
Django
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"5d383549eee498e4903fe290613d726a68615aca" 5d38354]:
{{{
#!CommitTicketReference repository=""
revision="5d383549eee498e4903fe290613d726a68615aca"
Refs #24152 -- Removed deprecated GeoQuerySet aggregate methods.
Per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24152#comment:8>