[Django] #28610: register_tests() for serializers test does not exhibit skipped formats

3 views
Skip to first unread message

Django

unread,
Sep 18, 2017, 4:05:31 AM9/18/17
to django-...@googlegroups.com
#28610: register_tests() for serializers test does not exhibit skipped formats
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
When running the serializers tests dynamically created by
`register_tests()`, and when a serializer is not available (for example
missing pyyaml), the test suite doesn't show any skipped test. It simply
ignores the missing tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/28610>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 18, 2017, 4:09:16 AM9/18/17
to django-...@googlegroups.com
#28610: register_tests() for serializers test does not exhibit skipped formats
--------------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/9102 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28610#comment:1>

Django

unread,
Sep 18, 2017, 8:33:34 AM9/18/17
to django-...@googlegroups.com
#28610: register_tests() for serializers test doesn't show skipped formats
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core | Version: master
(Serialization) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin
* component: Testing framework => Core (Serialization)


--
Ticket URL: <https://code.djangoproject.com/ticket/28610#comment:2>

Django

unread,
Sep 18, 2017, 1:47:08 PM9/18/17
to django-...@googlegroups.com
#28610: register_tests() for serializers test doesn't show skipped formats
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Core | Version: master
(Serialization) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"774f5548bdf976fc6f0f5ec3603723850a698f74" 774f5548]:
{{{
#!CommitTicketReference repository=""
revision="774f5548bdf976fc6f0f5ec3603723850a698f74"
Fixed #28610 -- Skipped test when serializer is not available

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28610#comment:3>

Reply all
Reply to author
Forward
0 new messages