[Django] #27305: Removed unused can_import_settings command attribute

3 views
Skip to first unread message

Django

unread,
Oct 2, 2016, 12:22:41 PM10/2/16
to django-...@googlegroups.com
#27305: Removed unused can_import_settings command attribute
-------------------------------------+-------------------------------------
Reporter: Claude | Owner: nobody
Paroz |
Type: | Status: new
Cleanup/optimization |
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
With various code updates these last months, the
`BaseCommand.can_import_settings` attribute is now unused. I'd suggest to
simply remove it.

--
Ticket URL: <https://code.djangoproject.com/ticket/27305>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 2, 2016, 12:25:51 PM10/2/16
to django-...@googlegroups.com
#27305: Removed unused can_import_settings command attribute
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7333 Pull request]

--
Ticket URL: <https://code.djangoproject.com/ticket/27305#comment:1>

Django

unread,
Oct 2, 2016, 1:55:06 PM10/2/16
to django-...@googlegroups.com
#27305: Removed unused can_import_settings command attribute
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27305#comment:2>

Django

unread,
Oct 2, 2016, 2:32:58 PM10/2/16
to django-...@googlegroups.com
#27305: Removed unused can_import_settings command attribute
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"122c90a43b2486bf278def8f068b6d1cebaa66f9" 122c90a4]:
{{{
#!CommitTicketReference repository=""
revision="122c90a43b2486bf278def8f068b6d1cebaa66f9"
Fixed #27305 -- Removed BaseCommand.can_import_settings unused attribute

Thanks Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27305#comment:3>

Reply all
Reply to author
Forward
0 new messages