[Django] #28164: Properly convert floats in DecimalField.to_python

21 views
Skip to first unread message

Django

unread,
May 3, 2017, 5:39:54 AM5/3/17
to django-...@googlegroups.com
#28164: Properly convert floats in DecimalField.to_python
-------------------------------------+-------------------------------------
Reporter: Claude | Owner: nobody
Paroz |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Referring to [https://groups.google.com/forum/#!msg/django-
developers/bnoVTOx2GFs/i0lNDpV8EgAJ this discussion], I think a first step
would be to properly convert float values in `DecimalField.to_python`. I'm
aware that a further step will be custom contexts (#26459).

--
Ticket URL: <https://code.djangoproject.com/ticket/28164>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 3, 2017, 5:43:17 AM5/3/17
to django-...@googlegroups.com
#28164: Properly convert floats in DecimalField.to_python
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8455 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28164#comment:1>

Django

unread,
May 5, 2017, 6:39:56 PM5/5/17
to django-...@googlegroups.com
#28164: Properly convert floats in DecimalField.to_python
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28164#comment:2>

Django

unread,
May 6, 2017, 5:53:24 AM5/6/17
to django-...@googlegroups.com
#28164: Properly convert floats in DecimalField.to_python
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/28164#comment:3>

Django

unread,
May 8, 2017, 8:24:52 PM5/8/17
to django-...@googlegroups.com
#28164: Properly convert floats in DecimalField.to_python
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28164#comment:4>

Django

unread,
May 9, 2017, 2:42:23 AM5/9/17
to django-...@googlegroups.com
#28164: Properly convert floats in DecimalField.to_python
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"a87189fc5e2e874219d20700cf811345138dd365" a87189fc]:
{{{
#!CommitTicketReference repository=""
revision="a87189fc5e2e874219d20700cf811345138dd365"
Fixed #28164 -- Improved float conversions in DecimalField.to_python

Thanks Tim Graham and Adam Johnson for the reviews.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28164#comment:5>

Reply all
Reply to author
Forward
0 new messages