[Django] #31952: Using EmptyFieldListFilter with reverse relationship crashes
Django
-------------------------------------------+------------------------
Reporter: felixxm | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
Using `EmptyFieldListFilter` with reverse relationship crashes because
they don't have `empty_strings_allowed` attribute. I reproduced this issue
with all types of reverse relationship:
{{{
AttributeError: 'ManyToManyRel' object has no attribute
'empty_strings_allowed'
AttributeError: 'ManyToOneRel' object has no attribute
'empty_strings_allowed'
AttributeError: 'OneToOneRel' object has no attribute
'empty_strings_allowed'
}}}
Thanks dacotagh for the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/31952>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: felixxm | Owner: Federico
| Jaramillo Martínez
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Federico Jaramillo Martínez):
* owner: nobody => Federico Jaramillo Martínez
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31952#comment:1>
Django
Reporter: felixxm | Owner: Federico
| Jaramillo Martínez
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Federico Jaramillo Martínez):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/13356 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31952#comment:2>
Django
Reporter: felixxm | Owner: Federico
| Jaramillo Martínez
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"c4e5384e739a1f79fe9f7d78431e3b48fcb09f48" c4e5384e]:
{{{
#!CommitTicketReference repository=""
revision="c4e5384e739a1f79fe9f7d78431e3b48fcb09f48"
[3.1.x] Fixed #31952 -- Fixed EmptyFieldListFilter crash with reverse
relationships.
Thanks dacotagh for the report.
Backport of 179d9dc0c2265176f9f7062a1d98dc44d896f91f from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31952#comment:4>
Django
Reporter: felixxm | Owner: Federico
| Jaramillo Martínez
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"179d9dc0c2265176f9f7062a1d98dc44d896f91f" 179d9dc0]:
{{{
#!CommitTicketReference repository=""
revision="179d9dc0c2265176f9f7062a1d98dc44d896f91f"
Fixed #31952 -- Fixed EmptyFieldListFilter crash with reverse
relationships.
Thanks dacotagh for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31952#comment:3>