[Django] #29815: InlineModelAdmin ignores media files from widgets included in the used form

[Django]

#29815: InlineModelAdmin ignores media files from widgets included in the used form
-----------------------------------------+------------------------
Reporter: godlark | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I have

{{{
class OpenSelectMultiple(Widget):
template_name = 'admin/forms/widgets/open_select.html'
option_template_name = 'django/forms/widgets/select_option.html'

class Media:
css = ('1.css',)
js = ('1.js', '2.js')

class OpenMultipleChoiceField(Field):
hidden_widget = MultipleHiddenInput
widget = OpenSelectMultiple
...

class NotificationFilterForm(forms.ModelForm):
prefixes = OpenMultipleChoiceField(required=False)

class NotificationFilterInline(admin.TabularInline):
extra = 0
model = NotificationFilter
form = NotificationFilterForm
}}}

Those files aren't included in the rendered page.

--
Ticket URL: <https://code.djangoproject.com/ticket/29815>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#29815: InlineModelAdmin ignores media files from widgets included in the used form

-------------------------------+--------------------------------------

Reporter: godlark | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+--------------------------------------
Changes (by godlark):

* version: 2.0 => 2.1

--
Ticket URL: <https://code.djangoproject.com/ticket/29815#comment:1>

[Django]

#29815: InlineModelAdmin ignores media files from widgets included in the used form

-------------------------------+--------------------------------------

Reporter: godlark | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+--------------------------------------

Old description:

> I have
>

> {{{
> class OpenSelectMultiple(Widget):
> template_name = 'admin/forms/widgets/open_select.html'
> option_template_name = 'django/forms/widgets/select_option.html'
>
> class Media:
> css = ('1.css',)
> js = ('1.js', '2.js')
>
> class OpenMultipleChoiceField(Field):
> hidden_widget = MultipleHiddenInput
> widget = OpenSelectMultiple
> ...
>
> class NotificationFilterForm(forms.ModelForm):
> prefixes = OpenMultipleChoiceField(required=False)
>
> class NotificationFilterInline(admin.TabularInline):
> extra = 0
> model = NotificationFilter
> form = NotificationFilterForm
> }}}
>
> Those files aren't included in the rendered page.

New description:

I have

{{{
class OpenSelectMultiple(Widget):
template_name = 'admin/forms/widgets/open_select.html'
option_template_name = 'django/forms/widgets/select_option.html'

class Media:
css = {'all':
('https://cdnjs.cloudflare.com/ajax/libs/selectize.js/0.12.6/css/selectize.default.min.css',)}

js = ('1.js', '2.js')

class OpenMultipleChoiceField(Field):
hidden_widget = MultipleHiddenInput
widget = OpenSelectMultiple
...

class NotificationFilterForm(forms.ModelForm):
prefixes = OpenMultipleChoiceField(required=False)

class NotificationFilterInline(admin.TabularInline):
extra = 0
model = NotificationFilter
form = NotificationFilterForm
}}}

Those files aren't included in the rendered page.

--

Comment (by godlark):

Correct use of css media

--
Ticket URL: <https://code.djangoproject.com/ticket/29815#comment:2>

[Django]

#29815: InlineModelAdmin ignores media files from widgets included in the used form

-----------------------------------+--------------------------------------
Reporter: Sławomir Domagała | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+--------------------------------------

Comment (by Tim Graham):

Can you debug the issue to find where the problem is? It looks to me like
[https://github.com/django/django/blob/bf8b625a3bb6c2cb5f1be3713f3bafe2c1050366/django/contrib/admin/options.py#L1597-L1599
media from inline formsets] is added correctly.

--
Ticket URL: <https://code.djangoproject.com/ticket/29815#comment:3>

[Django]

#29815: InlineModelAdmin ignores media files from widgets included in the used form

-----------------------------------+--------------------------------------
Reporter: Sławomir Domagała | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+--------------------------------------
Changes (by Sławomir Domagała):

* status: new => closed
* resolution: => invalid

Comment:

Replying to [comment:3 Tim Graham]:

> Can you debug the issue to find where the problem is? It looks to me
like
[https://github.com/django/django/blob/bf8b625a3bb6c2cb5f1be3713f3bafe2c1050366/django/contrib/admin/options.py#L1597-L1599
media from inline formsets] is added correctly.

Sorry, I was incorrectly using css media (I was trying to assing array to
css media instead dictionary) and it was failing silently. I thought that
the bug is
https://github.com/django/django/blob/bf8b625a3bb6c2cb5f1be3713f3bafe2c1050366/django/contrib/admin/options.py#L1990

--
Ticket URL: <https://code.djangoproject.com/ticket/29815#comment:4>