[Django] #32621: class names might follow pep8

30 views
Skip to first unread message

Django

unread,
Apr 8, 2021, 7:10:05 AM4/8/21
to django-...@googlegroups.com
#32621: class names might follow pep8
------------------------------------------------+------------------------
Reporter: BeryCZ | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Hi,
I've noticed that some class names don't follow pep 8 and it's quite
annoying to either remember or search for the right name.
What I know of rn is `JsonResponse` (which is right) and classes like
`JSONField`, `JSONCatalog`, `JSONString` and some more.
Would be nice to change the class names some time to `Json` and for
backward compatibility do `JSONField = JsonField`

--
Ticket URL: <https://code.djangoproject.com/ticket/32621>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 8, 2021, 7:14:33 AM4/8/21
to django-...@googlegroups.com
#32621: class names might follow pep8
-------------------------------------+-------------------------------------
Reporter: BeryCZ | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Uncategorized | Version: 3.2
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by BeryCZ:

Old description:

> Hi,
> I've noticed that some class names don't follow pep 8 and it's quite
> annoying to either remember or search for the right name.
> What I know of rn is `JsonResponse` (which is right) and classes like
> `JSONField`, `JSONCatalog`, `JSONString` and some more.
> Would be nice to change the class names some time to `Json` and for
> backward compatibility do `JSONField = JsonField`

New description:

Hi,
I've noticed that some class names don't follow pep 8 and it's quite
annoying to either remember or search for the right name.

What comes to mind rn is `JsonResponse` (which is ok) and classes like


`JSONField`, `JSONCatalog`, `JSONString` and some more.
Would be nice to change the class names some time to `Json` and for
backward compatibility do `JSONField = JsonField`

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32621#comment:1>

Django

unread,
Apr 8, 2021, 7:23:03 AM4/8/21
to django-...@googlegroups.com
#32621: class names might follow pep8
-------------------------------------+-------------------------------------
Reporter: BeryCZ | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Uncategorized | Version: 3.2
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by BeryCZ:

Old description:

> Hi,


> I've noticed that some class names don't follow pep 8 and it's quite
> annoying to either remember or search for the right name.

> What comes to mind rn is `JsonResponse` (which is ok) and classes like


> `JSONField`, `JSONCatalog`, `JSONString` and some more.
> Would be nice to change the class names some time to `Json` and for
> backward compatibility do `JSONField = JsonField`

New description:

Hi,
I've noticed that some class names don't follow pep 8 and it's quite
annoying to either remember or search for the right name.

What comes to mind rn is `JsonResponse` (which is ok) and classes like


`JSONField`, `JSONCatalog`, `JSONString` and some more.
Would be nice to change the class names some time to `Json` and for

backward compatibility to do `JSONField = JsonField`

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32621#comment:2>

Django

unread,
Apr 8, 2021, 7:41:39 AM4/8/21
to django-...@googlegroups.com
#32621: class names might follow pep8
-------------------------------------+-------------------------------------
Reporter: BeryCZ | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Core (Other) | Version: 3.2
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => wontfix
* component: Uncategorized => Core (Other)


Comment:

Thanks for this proposition.

> What comes to mind rn is JsonResponse (which is ok) and classes like
JSONField, JSONCatalog, JSONString and some more.

I would rather do the opposite, as suggested in #22895 and as we did for a
new API, e.g. `ASGIRequest`, `ASGIHandler`. Nonetheless, it's not worth to
change an existing API.

--
Ticket URL: <https://code.djangoproject.com/ticket/32621#comment:3>

Reply all
Reply to author
Forward
0 new messages