[Django] #29047: test_substr_with_expressions doesn't test expressions
Django
------------------------------------------------+------------------------
Reporter: Matthew Pava | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: 2.0
Severity: Normal | Keywords: Substr
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
The method implies that it tries to test the `Substr` function with
expressions, but it is just duplicated from the `test_substr` function and
does not use `Expression`s.
The method is in tests/db_functions/tests.py
--
Ticket URL: <https://code.djangoproject.com/ticket/29047>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Matthew Pava | Owner: Daniel
Type: | Hones
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: 2.0
Keywords: Substr | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Daniel Hones):
* owner: nobody => Daniel Hones
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29047#comment:1>
Django
Reporter: Matthew Pava | Owner: Daniel
Type: | Hones
Cleanup/optimization | Status: assigned
Keywords: Substr | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Daniel Hones):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/29047#comment:2>
Django
Reporter: Matthew Pava | Owner: Daniel
Type: | Hones
Component: Testing framework | Version: 2.0
Keywords: Substr | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9d129b72cea9e9e3850f3f657136ba3bbf6f633f" 9d129b72]:
{{{
#!CommitTicketReference repository=""
revision="9d129b72cea9e9e3850f3f657136ba3bbf6f633f"
Fixed #29047 -- Corrected Substr test to use expressions.
Regression in e2d6e14662d780383e18066a3182155fb5b7747b.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29047#comment:3>