[Django] #24882: Add documentation for Migration.run_before
Django
-------------------------------+--------------------
Reporter: coolRR | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/24882>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: coolRR | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Old description:
New description:
Reference
https://github.com/django/django/blob/c954931abd17f8efaa6b7662ac2916dbf47d2978/django/db/migrations/migration.py#L34-L37
Implemented in 5826dc52827254f44833acf678f429af94b4d636
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:1>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mcbhenwood):
* owner: nobody => mcbhenwood
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:2>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by mcbhenwood):
Pull Request: https://github.com/django/django/pull/4775
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:3>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mcbhenwood):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:4>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mcbhenwood):
* cc: mcbhenwood (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:5>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:6>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by MarkusH):
* cc: MarkusH (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:7>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by mcbhenwood):
I've addressed all the helpful PR comments apart from this one, where
instead I've explained why I disagree with the suggested alteration to my
sentence:
https://github.com/django/django/pull/4775#discussion_r31799563
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:8>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:9>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by MarkusH):
* stage: Accepted => Ready for checkin
Comment:
LGTM. Do you mind some spell and grammar checking before committing, Tim.
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:10>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"dee1bcd08a013ba5ffd8d1ec9b6628702f755066" dee1bcd0]:
{{{
#!CommitTicketReference repository=""
revision="dee1bcd08a013ba5ffd8d1ec9b6628702f755066"
Fixed #24882 -- Documented Migration.run_before
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:11>
Django
Reporter: coolRR | Owner:
Type: | mcbhenwood
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"f4c09d3e4273ac8946d6da1f4ee785ddb378ca19" f4c09d3]:
{{{
#!CommitTicketReference repository=""
revision="f4c09d3e4273ac8946d6da1f4ee785ddb378ca19"
[1.8.x] Fixed #24882 -- Documented Migration.run_before
Backport of dee1bcd08a013ba5ffd8d1ec9b6628702f755066 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24882#comment:12>