[Django] #21929: Regression with template_tests.test_loaders.EggLoaderTest

7 views
Skip to first unread message

Django

unread,
Feb 2, 2014, 1:46:07 PM2/2/14
to django-...@googlegroups.com
#21929: Regression with template_tests.test_loaders.EggLoaderTest
---------------------------------+--------------------
Reporter: manfre | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------
Test failure using sqlite on windows with Python 2.7.5.


{{{
=====================================================================
ERROR: test_existing (template_tests.test_loaders.EggLoaderTest)
A template can be loaded from an egg
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\project\django\django\django\test\utils.py", line 215, in inner
return test_func(*args, **kwargs)
File "D:\project\django\django\tests\template_tests\test_loaders.py",
line 100, in test_existing
contents, template_name = egg_loader.load_template_source("y.html")
File "D:\project\django\django\django\template\loaders\eggs.py", line
35, in load_template_source
raise TemplateDoesNotExist(template_name)
TemplateDoesNotExist: y.html
}}}


Bisected to
{{{

88a2d39159872f6a7fced1bae591550650fd7f38 is the first bad commit
commit 88a2d39159872f6a7fced1bae591550650fd7f38
Author: Carl Meyer <ca...@oddbird.net>
Date: Mon Jan 27 13:28:53 2014 -0700

Fixed #21874 -- Require Django applications to have a filesystem path.

Wherever possible this filesystem path is derived automatically from
the app
module's ``__path__`` and ``__file__`` attributes (this avoids any
backwards-compatibility problems).

AppConfig allows specifying an app's filesystem location explicitly,
which
overrides all autodetection based on ``__path__`` and ``__file__``.
This
permits Django to support any type of module as an app (namespace
packages,
fake modules, modules loaded by other hypothetical non-filesystem
module
loaders), as long as the app is configured with an explicit filesystem
path.

Thanks Aymeric for review and discussion.

:040000 040000 6a4b10be81d1598fd553f9fff13cb0963fb96703
17acb1bb401949ce52455e2ef22976f76ad92286 M django
:040000 040000 4cec000bb5b71e20dde44b47b9e2c855110ceed9
8295ed53f4adc11c968d4842f7e926a8176f8ccb M docs
:040000 040000 45ad7b6535b697b92615821b3b0dff98e3c32da6
b04d1d3382fe97af053f83576c6c5234b82733c8 M tests
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21929>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 4, 2014, 3:15:42 PM2/4/14
to django-...@googlegroups.com
#21929: Regression with template_tests.test_loaders.EggLoaderTest
-----------------------------+----------------------------
Reporter: manfre | Owner: nobody
Type: Bug | Status: closed

Component: Template system | Version: master
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------+----------------------------
Changes (by Carl Meyer <carl@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"2b272241809c939add6c81f312c479066e47c638"]:
{{{
#!CommitTicketReference repository=""
revision="2b272241809c939add6c81f312c479066e47c638"
Fixed #21929 - Fixed test regression on Windows.

Thanks Michael Manfre for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21929#comment:1>

Reply all
Reply to author
Forward
0 new messages