[Django] #29004: Create models from database views with inspectdb with "--include-views" option
Django
option
-------------------------------------+-------------------------------------
Reporter: Brendan | Owner: nobody
Quinn |
Type: New | Status: new
feature |
Component: Database | Version: master
layer (models, ORM) | Keywords: ORM, db, database
Severity: Normal | views
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I have added an option to the `inspectdb` admin command that creates
Django models from database views as well as tables.
Note that #25038 is related to this feature: someone thought it already
existed and wrote documentation for it. Hopefully now it works as the
initial poster assumed it would.
--
Ticket URL: <https://code.djangoproject.com/ticket/29004>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
option
-------------------------------------+-------------------------------------
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
[https://github.com/django/django/pull/9559 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
Patch looks good. (All feedback had been adopted.)
Just needs the `versionadded` comment and it's good to go.
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
views | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
I left a few comments for improvement.
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Component: Database layer | Version: master
(models, ORM) |
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"c2b969e124f65d375aac969f253279085b6f7078" c2b969e1]:
{{{
#!CommitTicketReference repository=""
revision="c2b969e124f65d375aac969f253279085b6f7078"
Fixed #29004 -- Added inspectdb --include-views option.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"c3a1337dfaa90baa58f0ecd647a595f7c57eb772" c3a1337d]:
{{{
#!CommitTicketReference repository=""
revision="c3a1337dfaa90baa58f0ecd647a595f7c57eb772"
Refs #29004 -- Optimized InspectDBTransactionalTests.test_include_views()
by limiting introspected tables.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"64f9776bc4a27a665032ac15f5176ced66e996e3" 64f9776]:
{{{
#!CommitTicketReference repository=""
revision="64f9776bc4a27a665032ac15f5176ced66e996e3"
Refs #29004 -- Prevented inspectdb tests from flushing all tables data.
This is a costly operation on most database backends.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Brendan Quinn | Owner: nobody
Type: New feature | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: ORM, db, database | Triage Stage: Accepted
views |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"f77dd56ead5eb562b6d005061d3b1370349298f1" f77dd56e]:
{{{
#!CommitTicketReference repository=""
revision="f77dd56ead5eb562b6d005061d3b1370349298f1"
[2.1.x] Refs #29004 -- Prevented inspectdb tests from flushing all tables
data.
This is a costly operation on most database backends.
Backport of 64f9776bc4a27a665032ac15f5176ced66e996e3 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29004#comment:10>