[Django] #31768: `django.http.request` `validate_domains` - should be optional "Invalid HTTP_HOST header"

112 views

Skip to first unread message

Django

unread,

Jul 6, 2020, 4:28:59 PM7/6/20

to django-...@googlegroups.com

#31768: `django.http.request` `validate_domains` - should be optional "Invalid
HTTP_HOST header"
------------------------------------------------+------------------------
Reporter: Mateusz Kurowski | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
https://github.com/django/django/blob/master/django/http/request.py#L129

Working with this, i cannot simply use docker host resolution because my
host is invalid:

Invalid HTTP_HOST header: 'my_service:8000'. The domain name provided is
not valid according to RFC 1034/1035.

This is really annoying as Django and any other project should !!never
ever!! force us to check thing that may be irrevelant for the user! Doing
this is the first cause of wasting time and workarounds for simple
problems - !! assuming that code knows better what the human needs is
wrong !!.
Just saying loudly what i think, no offense.

Can we work on this problem?

--
Ticket URL: <https://code.djangoproject.com/ticket/31768>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Jul 7, 2020, 3:44:01 AM7/7/20

to django-...@googlegroups.com

#31768: `django.http.request` `validate_domains` - should be optional "Invalid
HTTP_HOST header"

-------------------------------------+-------------------------------------

Reporter: Mateusz Kurowski | Owner: nobody

Type: | Status: closed
Cleanup/optimization |

Component: HTTP handling | Version: 3.0

Severity: Normal | Resolution: invalid

-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* status: new => closed
* resolution: => invalid

Comment:

[https://en.wikipedia.org/wiki/Hostname#Syntax Underscores are not
permitted in hostnames]. Remove the `_`:

{{{
>>> from django.http.request import split_domain_port
>>> split_domain_port('my_service:8000')
('', '')
>>> split_domain_port('myservice.com:8000')
('myservice.com', '8000')
>>> split_domain_port('my-service.com:8000')
('my-service.com', '8000')
}}}