[Django] #26674: i18n makemessages test failure on Python 3.x + Windows

[Django]

#26674: i18n makemessages test failure on Python 3.x + Windows
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Keywords: windows unicode
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
This is the failure:

{{{
======================================================================
FAIL: test_special_char_extracted
(i18n.test_extraction.BasicExtractorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\django\tests\i18n\test_extraction.py", line 219, in
test_special_char_extracted
File "C:\django\tests\i18n\test_extraction.py", line 87, in assertMsgId
File "C:\django\tests\i18n\test_extraction.py", line 84, in
_assertPoKeyword
AssertionError: None is not true : Could not find 'msgid "Non-breaking
space▒:"' in generated PO file
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26674>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#26674: i18n makemessages test failure on Python 3.x + Windows

--------------------------------------+------------------------------------
Reporter: ramiro | Owner: ramiro
Type: Bug | Status: assigned
Component: Internationalization | Version: master
Severity: Normal | Resolution:

Keywords: windows unicode | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by ramiro):

* status: new => assigned
* owner: nobody => ramiro

--
Ticket URL: <https://code.djangoproject.com/ticket/26674#comment:1>

[Django]

#26674: i18n makemessages test failure on Python 3.5 + Windows

--------------------------------------+------------------------------------
Reporter: ramiro | Owner: ramiro
Type: Bug | Status: assigned
Component: Internationalization | Version: master
Severity: Normal | Resolution:

Keywords: windows unicode | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/26674#comment:2>

[Django]

#26674: i18n makemessages test failure on Python 3.5 + Windows
-------------------------------------+-------------------------------------

Reporter: ramiro | Owner: ramiro
Type: Bug | Status: assigned

Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: windows unicode | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* has_patch: 0 => 1
* version: master => 1.10
* stage: Accepted => Ready for checkin

Comment:

[https://github.com/django/django/pull/6665 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26674#comment:3>

[Django]

#26674: i18n makemessages test failure on Python 3.5 + Windows
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: ramiro
Type: Bug | Status: closed
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution: fixed

Keywords: windows unicode | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Ramiro Morales <cramm0@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"1b00ed088073ffd268af15d25246d2565253536d" 1b00ed08]:
{{{
#!CommitTicketReference repository=""
revision="1b00ed088073ffd268af15d25246d2565253536d"
Fixed #26674 -- Corrected a i18n makemessages test.

Made it consistently read the PO file, decode its contents and then
check for the non-breaking space Unicode code point.

Previously we were erroneously skipping the interpretation of what we
read as UTF-8 text.

This was causing the test to fail on Windows with Python 3.5.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26674#comment:4>

[Django]

#26674: i18n makemessages test failure on Python 3.5 + Windows
-------------------------------------+-------------------------------------

Reporter: ramiro | Owner: ramiro
Type: Bug | Status: closed
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: windows unicode | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"af8ac46015f5bbed7c266df0ff8490e05282ab59" af8ac46]:
{{{
#!CommitTicketReference repository=""
revision="af8ac46015f5bbed7c266df0ff8490e05282ab59"
[1.10.x] Fixed #26674 -- Corrected a i18n makemessages test.

Made it consistently read the PO file, decode its contents and then
check for the non-breaking space Unicode code point.

Previously we were erroneously skipping the interpretation of what we
read as UTF-8 text.

This was causing the test to fail on Windows with Python 3.5.

Backport of 1b00ed088073ffd268af15d25246d2565253536d from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26674#comment:5>