[Django] #29300: Allow overriding INTERNAL_RESET_URL_TOKEN on PasswordResetConfirmView

2 views
Skip to first unread message

Django

unread,
Apr 7, 2018, 3:26:25 PM4/7/18
to django-...@googlegroups.com
#29300: Allow overriding INTERNAL_RESET_URL_TOKEN on PasswordResetConfirmView
------------------------------------------------+------------------------
Reporter: Mateusz Kurowski | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
Built in password reset view is really cool, but i don't understand why
these things are hard coded:

https://github.com/django/django/blob/aeb8c381789ad93866223f8bd07d09ae5e2edd9e/django/contrib/auth/views.py#L237

I am not sure what "easy pickings" mean but its an easy thing so i
selected that option.
Fix looks really trivial:

https://github.com/django/django/pull/9859

--
Ticket URL: <https://code.djangoproject.com/ticket/29300>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 7, 2018, 3:28:01 PM4/7/18
to django-...@googlegroups.com
#29300: Allow overriding INTERNAL_RESET_URL_TOKEN on PasswordResetConfirmView
-------------------------------------+-------------------------------------

Reporter: Mateusz Kurowski | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* status: new => closed
* resolution: => duplicate


Comment:

Duplicate of #28780.

--
Ticket URL: <https://code.djangoproject.com/ticket/29300#comment:1>

Reply all
Reply to author
Forward
0 new messages