[Django] #29783: There is no right validation in showmigrations command

35 views
Skip to first unread message

Django

unread,
Sep 22, 2018, 10:05:56 AM9/22/18
to django-...@googlegroups.com
#29783: There is no right validation in showmigrations command
-------------------------------------+-------------------------------------
Reporter: | Owner: Junyoung_Choi
Junyoung_Choi |
Type: | Status: assigned
Cleanup/optimization |
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
#29469
#29518
#29506

The app label validation was added to some commands as above tickets.
But `showmigrations` command doesn't contain it.
So I think the validation should be added to `showmigrations` command.

--
Ticket URL: <https://code.djangoproject.com/ticket/29783>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 22, 2018, 10:13:10 AM9/22/18
to django-...@googlegroups.com
#29783: There is no right validation in showmigrations command
-------------------------------------+-------------------------------------
Reporter: Junyoung_Choi | Owner:
Type: | Junyoung_Choi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Junyoung_Choi):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/10426

--
Ticket URL: <https://code.djangoproject.com/ticket/29783#comment:1>

Django

unread,
Sep 25, 2018, 11:15:58 AM9/25/18
to django-...@googlegroups.com
#29783: Add app_label validation to showmigrations

-------------------------------------+-------------------------------------
Reporter: Junyoung_Choi | Owner:
Type: | Junyoung_Choi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29783#comment:2>

Django

unread,
Sep 27, 2018, 8:59:00 PM9/27/18
to django-...@googlegroups.com
#29783: Add app_label validation to showmigrations
-------------------------------------+-------------------------------------
Reporter: Junyoung_Choi | Owner:
Type: | Junyoung_Choi
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1


Comment:

A test failure remains.

--
Ticket URL: <https://code.djangoproject.com/ticket/29783#comment:3>

Django

unread,
Oct 30, 2018, 8:19:38 PM10/30/18
to django-...@googlegroups.com
#29783: Add app_label validation to showmigrations
-------------------------------------+-------------------------------------
Reporter: Junyoung_Choi | Owner:
Type: | Junyoung_Choi
Cleanup/optimization | Status: closed

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"df448bfd0259edb7df19c9c445ab4ee58624245d" df448bfd]:
{{{
#!CommitTicketReference repository=""
revision="df448bfd0259edb7df19c9c445ab4ee58624245d"
Fixed #29783 -- Added app label validation to showmigrations command.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29783#comment:4>

Reply all
Reply to author
Forward
0 new messages