[Django] #30087: The error handling logic for empty default db config isn't tested

9 views
Skip to first unread message

Django

unread,
Jan 9, 2019, 8:48:37 AM1/9/19
to django-...@googlegroups.com
#30087: The error handling logic for empty default db config isn't tested
--------------------------------------------+------------------------
Reporter: Benjy Weinberger | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
Currently there is a test for the case of an entirely empty DATABASES
setting, but not for the case of a DATABASES setting that contains an
entry for DEFAULT_DB_ALIAS, but that entry is itself empty.

--
Ticket URL: <https://code.djangoproject.com/ticket/30087>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 9, 2019, 9:00:02 AM1/9/19
to django-...@googlegroups.com
#30087: The error handling logic for empty default db config isn't tested
----------------------------------+--------------------------------------

Reporter: Benjy Weinberger | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------

Comment (by Benjy Weinberger):

See branch https://github.com/benjyw/django/tree/ticket_30087

--
Ticket URL: <https://code.djangoproject.com/ticket/30087#comment:1>

Django

unread,
Jan 9, 2019, 9:01:18 AM1/9/19
to django-...@googlegroups.com
#30087: The error handling logic for empty default db config isn't tested
----------------------------------+--------------------------------------

Reporter: Benjy Weinberger | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------

Comment (by Benjy Weinberger):

See PR https://github.com/django/django/pull/10828

--
Ticket URL: <https://code.djangoproject.com/ticket/30087#comment:2>

Django

unread,
Jan 9, 2019, 9:01:27 AM1/9/19
to django-...@googlegroups.com
#30087: The error handling logic for empty default db config isn't tested
----------------------------------+--------------------------------------

Reporter: Benjy Weinberger | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Benjy Weinberger):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30087#comment:3>

Django

unread,
Jan 9, 2019, 10:59:00 AM1/9/19
to django-...@googlegroups.com
#30087: The error handling logic for empty default db config isn't tested
----------------------------------+--------------------------------------

Reporter: Benjy Weinberger | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 2.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"c2c85663e2dd06c9ed9c9ec2d02202d6d668d7f0" c2c85663]:
{{{
#!CommitTicketReference repository=""
revision="c2c85663e2dd06c9ed9c9ec2d02202d6d668d7f0"
Fixed #30087 -- Tested error handling for empty 'default' database.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30087#comment:4>

Django

unread,
Jan 9, 2019, 11:00:52 AM1/9/19
to django-...@googlegroups.com
#30087: The error handling logic for empty default db config isn't tested
-------------------------------------+-------------------------------------

Reporter: Benjy Weinberger | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* component: Uncategorized => Database layer (models, ORM)
* type: Uncategorized => Bug


--
Ticket URL: <https://code.djangoproject.com/ticket/30087#comment:5>

Reply all
Reply to author
Forward
0 new messages