[Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added
Django
-----------------------------------------+------------------------
Reporter: Shai Berger | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
When using a FilteredSelectMultiple as a widget for a MultipleChoice
field, typically the list of options is longer than what fits in the
control. If the user then scrolls down, selects some options, and clicks
the arrow to move them to the "chosen" box, then they are correctly added,
but the "available" box scrolls to the top.
It would be much nicer if the "available" box stayed where it was.
At [https://www.matific.com Matific] where we encountered this, we
monkeypatched the control's media to add a JavaScript file with this code:
{{{
(function($){
if(!SelectBox)
return;
var oldRedisplay = SelectBox.redisplay;
if(typeof oldRedisplay !== 'function')
return;
SelectBox.redisplay = function(id) {
var top = $('#'+id).scrollTop(); //record current scroll
var res = oldRedisplay.apply(this, arguments);
$('#'+id).scrollTop(top); // Restore the scroll
return res;
};
})(django.jQuery);
}}}
I'm attaching a minimal project to demonstrate it.
--
Ticket URL: <https://code.djangoproject.com/ticket/31522>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Shai Berger | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Shai Berger):
* Attachment "multiselect.tgz" added.
This project has a user "shai" with password "1" to log in to the admin in
the included database
Django
Reporter: Shai Berger | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+--------------------------------------
Changes (by Shai Berger):
* ui_ux: 0 => 1
* component: Uncategorized => contrib.admin
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:1>
Django
Reporter: Shai Berger | Owner: nobody
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+--------------------------------------
Changes (by Shai Berger):
* type: Uncategorized => Bug
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:2>
Django
Reporter: Shai Berger | Owner: TapanGujjar
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+---------------------------------------
Changes (by TapanGujjar):
* owner: nobody => TapanGujjar
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/12833
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* cc: TapanGujjar (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by TapanGujjar):
* needs_better_patch: 1 => 0
Comment:
https://github.com/django/django/pull/12833
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Shai Berger | Owner:
Type: | TapanGujjar
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2d67222472f80f251607ae1b720527afceba06ad" 2d672224]:
{{{
#!CommitTicketReference repository=""
revision="2d67222472f80f251607ae1b720527afceba06ad"
Fixed #31522 -- Made admin's SelectBox preserve scroll position.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31522#comment:10>