[Django] #20566: Store previous string in po files
Django
--------------------------------------+--------------------
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Currently while there is changed text to be translated, the string is only
marked fuzzy not providing translators any information what has been
changed. This can be improved by adding --previous parameter to msgmerge.
There is pull request to implement this at
https://github.com/django/django/pull/627
--
Ticket URL: <https://code.djangoproject.com/ticket/20566>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ramiro):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:1>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by claudep):
Will we really offer a management command option for each msgmerge option?
What about switching on the `--previous` flag without adding yet another
option?
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:2>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by wim@…):
@claudep I think it is nice to provide backwards compatibility, though I
don't find it necessary for myself.
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:3>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by claudep):
I don't see any backwards compatibility issue with `--previous`.
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:4>
Django
Reporter: nijel | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):
* status: new => closed
* needs_better_patch: 0 => 1
* component: Internationalization => contrib.admin
* needs_tests: 0 => 1
* version: 1.5 => master
* easy: 0 => 1
* type: New feature => Uncategorized
* keywords: => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* resolution: => fixed
* stage: Accepted => Unreviewed
Comment:
1
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:5>
Django
Reporter: nijel | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):
* keywords: => 1
* type: New feature => Uncategorized
* version: 1.5 => master
* component: Internationalization => contrib.admin
Comment:
1
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:6>
Django
Reporter: nijel | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by ogpcludi <sample@…>):
1
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:7>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by ramiro):
+1 to Claude proposal. And I don't see any backward incompatibility danger
either, any 3rd. party tool handling GNU gettext catalog files should
handle (ignore) these comments gracefully.
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:5>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by ramiro):
Also, the PR actually proposes making the new behavior (adding the old
literal as a comment) the default. And it adds a command line switch to
get the old behavior. Maybe we can drop the latter one? (sorry if this was
what you meant in the first place).
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:6>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by claudep):
Just attached how I would like to solve this issue (proof-of-concept,
untested). If such an approach would be accepted, we then need to document
the new class-level attributes and encourage people to subclass and
override to customize behaviour.
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:7>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by nijel):
The only reason I've added command option was to follow current state
where the options were provided. It would be probably about as useful as
`--no-location`. Proposed patch looks good to me as it quite simplifies
the code.
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:8>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:9>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: new
Component: Internationalization | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by anonymous):
Simplified pull request: https://github.com/django/django/pull/2398
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:10>
Django
Reporter: nijel | Owner: nobody
Type: New feature | Status: closed
Component: Internationalization | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* status: new => closed
Comment:
Argh, sorry. Forgot to add ticket number in the fixing commit:
[06efeae598c6dafbe56d2ea323a0dccdd5bf2b8e]
Added --previous flag to msgmerge command used by makemessages
Also took the opportunity to slightly refactor gettext options
so as to ease customization by subclassing the command.
Thanks Michal Čihař for the report and initial patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/20566#comment:11>