[Django] #25402: logging.dict.dictConfig should not be called when LOGGING_CONFIG is defined

2 views
Skip to first unread message

Django

unread,
Sep 14, 2015, 2:43:12 PM9/14/15
to django-...@googlegroups.com
#25402: logging.dict.dictConfig should not be called when LOGGING_CONFIG is defined
-------------------------------+--------------------
Reporter: jawnb | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
I feel like a call to dictConfig defeats the purpose of defining
LOGGING_CONFIG.

Ideally LOGGING_CONFIG should be the one responsible for doing all the
logging definitions.

Code is here:
https://github.com/django/django/blob/5153a3bfdcec82324d67ff79862384288cf6afe6/django/utils/log.py#L65

--
Ticket URL: <https://code.djangoproject.com/ticket/25402>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 14, 2015, 3:18:36 PM9/14/15
to django-...@googlegroups.com
#25402: logging.dict.dictConfig should not be called when LOGGING_CONFIG is defined
-------------------------------------+-------------------------------------
Reporter: jawnb | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Core (Other) | Version: 1.8
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: new => closed
* needs_better_patch: => 0
* component: Uncategorized => Core (Other)
* needs_tests: => 0
* type: Uncategorized => Cleanup/optimization
* needs_docs: => 0
* resolution: => wontfix


Comment:

Have you read [https://docs.djangoproject.com/en/1.8/topics/logging
/#configuring-logging the documentation about this]? Your proposal isn't
backwards compatible as far as I can tell, so if you want to argue for
that change, you should do so on the DevelopersMailingList. Thanks!

--
Ticket URL: <https://code.djangoproject.com/ticket/25402#comment:1>

Reply all
Reply to author
Forward
0 new messages