[Django] #27261: Mismatch for placholders in japanese translations (django.contrib.admin app)
Django
app)
-------------------------------+----------------------------------------
Reporter: Maxime Vdb | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Keywords: translation japanese admin
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+----------------------------------------
Hi there,
I found out there is a mismatch in the placeholders between a translation
message id and its actual translation in Japanese. You can find the
strings
[https://github.com/django/django/blob/1.10.1/django/contrib/admin/locale/ja/LC_MESSAGES/django.po#L146-L147
here] (here is
[https://github.com/django/django/blob/2ced2f785d5aca0354abf5841d5449b7a49509dc/django/contrib/admin/models.py#L119-L121
the code] that uses this string).
I don't know what is your process to do that but I'll be glad to help.
Also, I discovered that because we have unit-tests that compare the
strings and their translations and look for mismatches in their
placeholders. We could easily implement such a unit test in Django itself.
--
Ticket URL: <https://code.djangoproject.com/ticket/27261>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
app)
Reporter: Maxime Vdb | Owner: nobody
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: translation | Triage Stage:
japanese admin | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* needs_docs: => 0
* type: Uncategorized => Bug
* easy: 1 => 0
* needs_tests: => 0
* needs_better_patch: => 0
Comment:
Translations are done through
[https://docs.djangoproject.com/en/dev/internals/contributing/localizing/#translations
Transifex]. Assuming this can be fixed there, then you can close the
ticket as we don't use Trac to coordinate that work.
--
Ticket URL: <https://code.djangoproject.com/ticket/27261#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Maxime Vdb | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: translation | Triage Stage: Accepted
japanese admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: new => assigned
* owner: nobody => Claude Paroz
* stage: Unreviewed => Accepted
Comment:
As Tim said, you should fix the string on Transifex.
However, this reveals a bug in that the offended original string misses
the `#, python-brace-format` marker in the base
`en/LC_MESSAGES/django.po`. I'll fix that.
With the proper marker, this error should have been caught by the gettext
check program (msgfmt -vc).
--
Ticket URL: <https://code.djangoproject.com/ticket/27261#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Maxime Vdb | Owner: Claude
| Paroz
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: translation | Triage Stage: Accepted
japanese admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2c501203601c9610e69155c57bfe235f155344e2" 2c50120]:
{{{
#!CommitTicketReference repository=""
revision="2c501203601c9610e69155c57bfe235f155344e2"
Fixed #27261 -- Added missing python-brace-format marker
Thanks Maxime Vdb for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27261#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Maxime Vdb | Owner: Claude
| Paroz
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: translation | Triage Stage: Accepted
japanese admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"90949a156a2a7b67b52db4b2b53776a7016fda09" 90949a15]:
{{{
#!CommitTicketReference repository=""
revision="90949a156a2a7b67b52db4b2b53776a7016fda09"
[1.10.x] Fixed #27261 -- Added missing python-brace-format marker
Thanks Maxime Vdb for the report.
Backport of 2c501203601c9610e69155c57bfe235f155344e2 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27261#comment:4>