[Django] #26620: refresh_from_db() shouldn't ignore unknown keyword argumengs
Django
----------------------------------------------+--------------------
Reporter: intgr | Owner: intgr
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+--------------------
This code should raise a TypeError, but for some reason unknown keyword
arguments are ignored:
{{{
a.refresh_from_db(unknown_kwarg=10)
}}}
Dunno if this is considered a bug or cleanup, but it can hide real
mistakes in code.
--
Ticket URL: <https://code.djangoproject.com/ticket/26620>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: intgr | Owner: intgr
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* cc: akaariai (added)
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0
Comment:
Anssi, did you have a reason for the original design?
--
Ticket URL: <https://code.djangoproject.com/ticket/26620#comment:1>
Django
Reporter: intgr | Owner: intgr
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by akaariai):
I don't recall doing this intentionally. So, +1 to fixing it.
--
Ticket URL: <https://code.djangoproject.com/ticket/26620#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: intgr | Owner: intgr
Type: Bug | Status: new
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by timgraham):
* cc: akaariai (removed)
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/26620#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: intgr | Owner: intgr
Type: Bug | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"b9ae662c97534ab01329dae966222b6ed0185034" b9ae662]:
{{{
#!CommitTicketReference repository=""
revision="b9ae662c97534ab01329dae966222b6ed0185034"
Fixed #26620 -- Made Model.refresh_from_db() fail when passed unknown
kwargs.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26620#comment:4>